diff options
author | julie <julielangou@users.noreply.github.com> | 2016-01-19 05:05:15 +0000 |
---|---|---|
committer | julie <julielangou@users.noreply.github.com> | 2016-01-19 05:05:15 +0000 |
commit | 3e0fca84a48689bc806729582537d3b699f25c6e (patch) | |
tree | eb415a83b19209d35a72b1b51b9012f0149eb135 /TESTING/EIG/dspt21.f | |
parent | 32379b9f5ed6ad6327292c7a542193c51b4cfa2b (diff) | |
download | lapack-3e0fca84a48689bc806729582537d3b699f25c6e.tar.gz lapack-3e0fca84a48689bc806729582537d3b699f25c6e.tar.bz2 lapack-3e0fca84a48689bc806729582537d3b699f25c6e.zip |
Commit David fix - sent on Jan 16th 2016 directly
Confirmed by Julie on Jan 18th 2016
Note: issue (1) was fixed in previous commit
Message from David
(1) Line 147 of SRC/zgetrf2.f contains the following code:
EXTERNAL ZGEMM, ZSCAL, ZLASWP, ZTRSM, ZERBLA
Inspection of the zgetrf2.f code suggests that ZERBLA on line 147 should in fact be replaced by XERBLA.
--> [JULIE] This was fixed in our SVN on Dec 7th, 2015, revision 1664
(2) Lines 444 to 447 of TESTING\EIG\cdrvbd.f contains the following code:
EXTERNAL ALASVM, XERBLA, CBDT01, CBDT05, CGESDD, CGESVD,
$ CGESVJ, CGEJSV, CGESVDX, CLACPY, CLASET, CLATMS,
$ CUNT01, CUNT03
Since the length of line 445 is 73 characters the comma at the end of that line is truncated and a symbol CLATMSCUNT01 is erroneously defined. Then during linking an error is generated because this erroneously defined symbol cannot be found.
** Recommendation ** The developers reformat all code to ensure strict adherence to the standard 72 column formatting of fixed format source files. As is well known violation of this formatting rule can result in subtle undetected errors.
(3) Similar formatting errors to that in (2) have been detected in:
TESTING\EIG\zdrvbd.f (line 445)
TESTING\EIG\dchkbd.f (line 548)
TESTING\EIG\ddrvbd.f (line 407)
TESTING\EIG\derrbd.f (line 92)
TESTING\EIG\schkbd.f (line 548)
TESTING\EIG\sdrvbd.f (line 407)
TESTING\EIG\serrbd.f (line 92)
(4) Lines 103 to 104 of TESTING\EIG\cerred.f contains the following code:
EXTERNAL CHKXER, CGEES, CGEESX, CGEEV, CGEEVX, CGEJSV
$ CGESDD, CGESVD
There is a comma missing from the end of line 103. This does not result in a compilation error. Rather an invalid symbol CGEJSVCGESDD is defined which ultimately causes an error during linking.
Diffstat (limited to 'TESTING/EIG/dspt21.f')
0 files changed, 0 insertions, 0 deletions