Commit David fix - sent on Jan 16th 2016 directly

Confirmed by Julie on Jan 18th 2016
Note: issue (1) was fixed in previous commit

Message from David

(1) Line 147 of SRC/zgetrf2.f contains the following code:
 
      EXTERNAL           ZGEMM, ZSCAL, ZLASWP, ZTRSM, ZERBLA
 
Inspection of the zgetrf2.f code suggests that ZERBLA on line 147 should in fact be replaced by XERBLA.

--> [JULIE] This was fixed in our SVN on Dec 7th, 2015, revision 1664

 
(2) Lines 444 to 447 of  TESTING\EIG\cdrvbd.f contains the following code:
 
      EXTERNAL           ALASVM, XERBLA, CBDT01, CBDT05, CGESDD, CGESVD,
     $                   CGESVJ, CGEJSV, CGESVDX, CLACPY, CLASET, CLATMS,
     $                   CUNT01, CUNT03
 
Since the length of line 445 is 73 characters the comma at the end of that line is truncated and a symbol CLATMSCUNT01 is erroneously defined. Then during linking an error is generated because this erroneously defined symbol cannot be found.
 
** Recommendation ** The developers reformat all code to ensure strict adherence to the standard 72 column formatting of fixed format source files. As is well known violation of this formatting rule can result in subtle undetected errors.

 
(3) Similar formatting errors to that in (2) have been detected in:
TESTING\EIG\zdrvbd.f (line 445)
TESTING\EIG\dchkbd.f (line 548)
TESTING\EIG\ddrvbd.f (line 407)
TESTING\EIG\derrbd.f (line 92)
TESTING\EIG\schkbd.f (line 548)
TESTING\EIG\sdrvbd.f (line 407)
TESTING\EIG\serrbd.f (line 92)
 
(4) Lines 103 to 104 of TESTING\EIG\cerred.f contains the following code:

 
      EXTERNAL           CHKXER, CGEES, CGEESX, CGEEV, CGEEVX, CGEJSV
     $                   CGESDD, CGESVD
 
There is a comma missing from the end of line 103. This does not result in a compilation error. Rather an invalid symbol CGEJSVCGESDD is defined which ultimately causes an error during linking.

11 files changed, 51 insertions, 50 deletions

diff --git a/TESTING/EIG/cchkbd.f b/TESTING/EIG/cchkbd.f
index f5d99821..52417a69 100644
--- a/TESTING/EIG/cchkbd.f
+++ b/TESTING/EIG/cchkbd.f
@@ -466,9 +466,10 @@
       EXTERNAL           SLAMCH, SLARND
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           ALASUM, CBDSQR, CBDT01, CBDT02, CBDT03, CGEBRD,
-     $                   CGEMM, CLACPY, CLASET, CLATMR, CLATMS, CUNGBR,
-     $                   CUNT01, SCOPY, SLABAD, SLAHD2, SSVDCH, XERBLA
+      EXTERNAL           ALASUM, CBDSQR, CBDT01, CBDT02, CBDT03,
+     $                   CGEBRD, CGEMM, CLACPY, CLASET, CLATMR, 
+     $                   CLATMS, CUNGBR, CUNT01, SCOPY, SLABAD,
+     $                   SLAHD2, SSVDCH, XERBLA
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, EXP, INT, LOG, MAX, MIN, SQRT
@@ -483,9 +484,9 @@
       COMMON             / SRNAMC / SRNAMT
 *     ..
 *     .. Data statements ..
-      DATA               KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
-      DATA               KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
-      DATA               KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
+      DATA            KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
+      DATA            KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
+      DATA            KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
      $                   0, 0, 0 /
 *     ..
 *     .. Executable Statements ..
diff --git a/TESTING/EIG/cdrvbd.f b/TESTING/EIG/cdrvbd.f
index 28d863de..5381b144 100644
--- a/TESTING/EIG/cdrvbd.f
+++ b/TESTING/EIG/cdrvbd.f
@@ -423,11 +423,11 @@
 *     .. Local Scalars ..
       LOGICAL            BADMM, BADNN
       CHARACTER          JOBQ, JOBU, JOBVT, RANGE
-      INTEGER            I, IINFO, IJQ, IJU, IJVT, IL, IU, ITEMP, IWSPC,
-     $                   IWTMP, J, JSIZE, JTYPE, LSWORK, M, MINWRK,
-     $                   MMAX, MNMAX, MNMIN, MTYPES, N, NERRS, NFAIL,
-     $                   NMAX, NS, NSI, NSV, NTEST, NTESTF, NTESTT,
-     $                   LRWORK
+      INTEGER            I, IINFO, IJQ, IJU, IJVT, IL, IU, ITEMP,
+     $                   IWSPC, IWTMP, J, JSIZE, JTYPE, LSWORK, M,
+     $                   MINWRK, MMAX, MNMAX, MNMIN, MTYPES, N,
+     $                   NERRS, NFAIL, NMAX, NS, NSI, NSV, NTEST,
+     $                   NTESTF, NTESTT, LRWORK
       REAL               ANORM, DIF, DIV, OVFL, RTUNFL, ULP, ULPINV, 
      $                   UNFL, VL, VU
 *     ..
@@ -441,9 +441,9 @@
       EXTERNAL           SLAMCH, SLARND
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           ALASVM, XERBLA, CBDT01, CBDT05, CGESDD, CGESVD,
-     $                   CGESVJ, CGEJSV, CGESVDX, CLACPY, CLASET, CLATMS, 
-     $                   CUNT01, CUNT03
+      EXTERNAL           ALASVM, XERBLA, CBDT01, CBDT05, CGESDD,
+     $                   CGESVD, CGESVJ, CGEJSV, CGESVDX, CLACPY,
+     $                   CLASET, CLATMS, CUNT01, CUNT03
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, REAL, MAX, MIN
diff --git a/TESTING/EIG/cerred.f b/TESTING/EIG/cerred.f
index 564d58b7..99e3cca7 100644
--- a/TESTING/EIG/cerred.f
+++ b/TESTING/EIG/cerred.f
@@ -100,7 +100,7 @@
      $                   VT( NMAX, NMAX ), W( 10*NMAX ), X( NMAX )
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           CHKXER, CGEES, CGEESX, CGEEV, CGEEVX, CGEJSV
+      EXTERNAL           CHKXER, CGEES, CGEESX, CGEEV, CGEEVX, CGEJSV,
      $                   CGESDD, CGESVD
 *     ..
 *     .. External Functions ..
diff --git a/TESTING/EIG/dchkbd.f b/TESTING/EIG/dchkbd.f
index f9790692..cf0ad14f 100644
--- a/TESTING/EIG/dchkbd.f
+++ b/TESTING/EIG/dchkbd.f
@@ -545,10 +545,10 @@
       EXTERNAL           DLAMCH, DLARND, DSXT1
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           ALASUM, DBDSDC, DBDSQR, DBDSVDX, DBDT01, DBDT02, 
-     $                   DBDT03, DBDT04, DCOPY, DGEBRD, DGEMM, DLABAD, 
-     $                   DLACPY, DLAHD2, DLASET, DLATMR, DLATMS,
-     $                   DORGBR, DORT01, XERBLA
+      EXTERNAL           ALASUM, DBDSDC, DBDSQR, DBDSVDX, DBDT01,  
+     $                   DBDT02, DBDT03, DBDT04, DCOPY, DGEBRD,
+     $                   DGEMM, DLABAD, DLACPY, DLAHD2, DLASET, 
+     $                   DLATMR, DLATMS, DORGBR, DORT01, XERBLA
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, EXP, INT, LOG, MAX, MIN, SQRT
@@ -563,10 +563,10 @@
       COMMON             / SRNAMC / SRNAMT
 *     ..
 *     .. Data statements ..
-      DATA               KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
-      DATA               KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
-      DATA               KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
-     $                   0, 0, 0 /
+      DATA            KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
+      DATA            KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
+      DATA            KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
+     $                0, 0, 0 /
 *     ..
 *     .. Executable Statements ..
 *
diff --git a/TESTING/EIG/ddrvbd.f b/TESTING/EIG/ddrvbd.f
index d7340566..6d671f3b 100644
--- a/TESTING/EIG/ddrvbd.f
+++ b/TESTING/EIG/ddrvbd.f
@@ -404,8 +404,8 @@
 *     ..
 *     .. External Subroutines ..
       EXTERNAL           ALASVM, DBDT01, DGEJSV, DGESDD, DGESVD, 
-     $                   DGESVDX, DGESVJ, DLABAD, DLACPY, DLASET, DLATMS,
-     $                   DORT01, DORT03, XERBLA
+     $                   DGESVDX, DGESVJ, DLABAD, DLACPY, DLASET,
+     $                   DLATMS, DORT01, DORT03, XERBLA
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, DBLE, INT, MAX, MIN
diff --git a/TESTING/EIG/derrbd.f b/TESTING/EIG/derrbd.f
index da03504c..8726d2e7 100644
--- a/TESTING/EIG/derrbd.f
+++ b/TESTING/EIG/derrbd.f
@@ -89,8 +89,8 @@
       EXTERNAL           LSAMEN
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           CHKXER, DBDSDC, DBDSQR, DBDSVDX, DGEBD2, DGEBRD, DORGBR,
-     $                   DORMBR
+      EXTERNAL           CHKXER, DBDSDC, DBDSQR, DBDSVDX, DGEBD2,
+     $                   DGEBRD, DORGBR, DORMBR
 *     ..
 *     .. Scalars in Common ..
       LOGICAL            LERR, OK
diff --git a/TESTING/EIG/schkbd.f b/TESTING/EIG/schkbd.f
index 3419c7df..f7e88309 100644
--- a/TESTING/EIG/schkbd.f
+++ b/TESTING/EIG/schkbd.f
@@ -527,7 +527,7 @@
       CHARACTER*3        PATH
       INTEGER            I, IINFO, IL, IMODE, ITEMP, ITYPE, IU, IWBD, 
      $                   IWBE, IWBS, IWBZ, IWWORK, J, JCOL, JSIZE,
-     $                   JTYPE, LOG2UI, M, MINWRK, MMAX, MNMAX, MNMIN, 
+     $                   JTYPE, LOG2UI, M, MINWRK, MMAX, MNMAX, MNMIN,
      $                   MNMIN2, MQ, MTYPES, N, NFAIL, NMAX, 
      $                   NS1, NS2, NTEST
       REAL               ABSTOL, AMNINV, ANORM, COND, OVFL, RTOVFL, 
@@ -545,10 +545,10 @@
       EXTERNAL           SLAMCH, SLARND, SSXT1
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           ALASUM, SBDSDC, SBDSQR, SBDSVDX, SBDT01, SBDT02, 
-     $                   SBDT03, SBDT04, SCOPY, SGEBRD, SGEMM, SLABAD, 
-     $                   SLACPY, SLAHD2, SLASET, SLATMR, SLATMS,
-     $                   SORGBR, SORT01, XERBLA
+      EXTERNAL           ALASUM, SBDSDC, SBDSQR, SBDSVDX, SBDT01,  
+     $                   SBDT02, SBDT03, SBDT04, SCOPY, SGEBRD, 
+     $                   SGEMM, SLABAD, SLACPY, SLAHD2, SLASET,
+     $                   SLATMR, SLATMS, SORGBR, SORT01, XERBLA
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, EXP, INT, LOG, MAX, MIN, SQRT
@@ -563,9 +563,9 @@
       COMMON             / SRNAMC / SRNAMT
 *     ..
 *     .. Data statements ..
-      DATA               KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
-      DATA               KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
-      DATA               KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
+      DATA            KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
+      DATA            KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
+      DATA            KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
      $                   0, 0, 0 /
 *     ..
 *     .. Executable Statements ..
diff --git a/TESTING/EIG/sdrvbd.f b/TESTING/EIG/sdrvbd.f
index 0eeddb8f..71260dce 100644
--- a/TESTING/EIG/sdrvbd.f
+++ b/TESTING/EIG/sdrvbd.f
@@ -404,8 +404,8 @@
 *     ..
 *     .. External Subroutines ..
       EXTERNAL           ALASVM, SBDT01, SGEJSV, SGESDD, SGESVD, 
-     $                   SGESVDX, SGESVJ, SLABAD, SLACPY, SLASET, SLATMS,
-     $                   SORT01, SORT03, XERBLA
+     $                   SGESVDX, SGESVJ, SLABAD, SLACPY, SLASET,
+     $                   SLATMS, SORT01, SORT03, XERBLA
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, REAL, INT, MAX, MIN
diff --git a/TESTING/EIG/serrbd.f b/TESTING/EIG/serrbd.f
index fbd1c2eb..72cb5d21 100644
--- a/TESTING/EIG/serrbd.f
+++ b/TESTING/EIG/serrbd.f
@@ -89,8 +89,8 @@
       EXTERNAL           LSAMEN
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           CHKXER, SBDSDC, SBDSQR, SBDSVDX, SGEBD2, SGEBRD, SORGBR,
-     $                   SORMBR
+      EXTERNAL           CHKXER, SBDSDC, SBDSQR, SBDSVDX, SGEBD2,
+     $                   SGEBRD, SORGBR, SORMBR
 *     ..
 *     .. Scalars in Common ..
       LOGICAL            LERR, OK
diff --git a/TESTING/EIG/zchkbd.f b/TESTING/EIG/zchkbd.f
index f126e47c..61aca7d7 100644
--- a/TESTING/EIG/zchkbd.f
+++ b/TESTING/EIG/zchkbd.f
@@ -483,9 +483,9 @@
       COMMON             / SRNAMC / SRNAMT
 *     ..
 *     .. Data statements ..
-      DATA               KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
-      DATA               KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
-      DATA               KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
+      DATA            KTYPE / 1, 2, 5*4, 5*6, 3*9, 10 /
+      DATA            KMAGN / 2*1, 3*1, 2, 3, 3*1, 2, 3, 1, 2, 3, 0 /
+      DATA            KMODE / 2*0, 4, 3, 1, 4, 4, 4, 3, 1, 4, 4, 0,
      $                   0, 0, 0 /
 *     ..
 *     .. Executable Statements ..
diff --git a/TESTING/EIG/zdrvbd.f b/TESTING/EIG/zdrvbd.f
index 2f1e3cc3..488880e8 100644
--- a/TESTING/EIG/zdrvbd.f
+++ b/TESTING/EIG/zdrvbd.f
@@ -423,11 +423,11 @@
 *     .. Local Scalars ..
       LOGICAL            BADMM, BADNN
       CHARACTER          JOBQ, JOBU, JOBVT, RANGE
-      INTEGER            I, IINFO, IJQ, IJU, IJVT, IL, IU, ITEMP, IWSPC,
-     $                   IWTMP, J, JSIZE, JTYPE, LSWORK, M, MINWRK,
-     $                   MMAX, MNMAX, MNMIN, MTYPES, N, NERRS, NFAIL,
-     $                   NMAX, NS, NSI, NSV, NTEST, NTESTF, NTESTT,
-     $                   LRWORK
+      INTEGER            I, IINFO, IJQ, IJU, IJVT, IL, IU, ITEMP, 
+     $                   IWSPC, IWTMP, J, JSIZE, JTYPE, LSWORK, M, 
+     $                   MINWRK, MMAX, MNMAX, MNMIN, MTYPES, N, 
+     $                   NERRS, NFAIL, NMAX, NS, NSI, NSV, NTEST, 
+     $                   NTESTF, NTESTT, LRWORK
       DOUBLE PRECISION   ANORM, DIF, DIV, OVFL, RTUNFL, ULP, ULPINV, 
      $                   UNFL, VL, VU
 *     ..
@@ -441,9 +441,9 @@
       EXTERNAL           DLAMCH, DLARND
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           ALASVM, XERBLA, ZBDT01, ZBDT05, ZGESDD, ZGESVD,
-     $                   ZGESVJ, ZGEJSV, ZGESVDX, ZLACPY, ZLASET, ZLATMS,  
-     $                   ZUNT01, ZUNT03
+      EXTERNAL           ALASVM, XERBLA, ZBDT01, ZBDT05, ZGESDD,
+     $                   ZGESVD, ZGESVJ, ZGEJSV, ZGESVDX, ZLACPY,  
+     $                   ZLASET, ZLATMS, ZUNT01, ZUNT03
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ABS, DBLE, MAX, MIN