diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-06-17 21:54:38 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-07-06 18:54:13 -0700 |
| commit | d2613415433b505657402cc3774ddc8e01379a55 (patch) | |
| tree | c69d952457130398e5d4a47c18e40e7ece9aaa89 /drivers/target | |
| parent | 2152a122cdec4adcfcdd123ee6ab93867b35d5b5 (diff) | |
| download | linux-3.10-d2613415433b505657402cc3774ddc8e01379a55.tar.gz linux-3.10-d2613415433b505657402cc3774ddc8e01379a55.tar.bz2 linux-3.10-d2613415433b505657402cc3774ddc8e01379a55.zip | |
iscsi-target: Explicily clear login response PDU in exception path
commit 683497566d48f86e04d026de1ee658dd74fc1077 upstream.
This patch adds a explicit memset to the login response PDU
exception path in iscsit_tx_login_rsp().
This addresses a regression bug introduced in commit baa4d64b
where the initiator would end up not receiving the login
response and associated status class + detail, before closing
the login connection.
Reported-by: Christophe Vu-Brugier <cvubrugier@yahoo.fr>
Tested-by: Christophe Vu-Brugier <cvubrugier@yahoo.fr>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/iscsi/iscsi_target_util.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c index 77dad2474c8..c9790f6fdd8 100644 --- a/drivers/target/iscsi/iscsi_target_util.c +++ b/drivers/target/iscsi/iscsi_target_util.c @@ -1288,6 +1288,8 @@ int iscsit_tx_login_rsp(struct iscsi_conn *conn, u8 status_class, u8 status_deta login->login_failed = 1; iscsit_collect_login_stats(conn, status_class, status_detail); + memset(&login->rsp[0], 0, ISCSI_HDR_LEN); + hdr = (struct iscsi_login_rsp *)&login->rsp[0]; hdr->opcode = ISCSI_OP_LOGIN_RSP; hdr->status_class = status_class; |