diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-06-20 10:59:57 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-07-06 18:54:13 -0700 |
| commit | 2152a122cdec4adcfcdd123ee6ab93867b35d5b5 (patch) | |
| tree | 4f0cc3ce1b2b95b666d8f396b5e9ac2fa88c829c /drivers/target | |
| parent | 69256ce37fa37dc92680579c4e4a73f15fe79d36 (diff) | |
| download | linux-3.10-2152a122cdec4adcfcdd123ee6ab93867b35d5b5.tar.gz linux-3.10-2152a122cdec4adcfcdd123ee6ab93867b35d5b5.tar.bz2 linux-3.10-2152a122cdec4adcfcdd123ee6ab93867b35d5b5.zip | |
iscsi-target: Avoid rejecting incorrect ITT for Data-Out
commit 97c99b47ac58bacb7c09e1f47d5d184434f6b06a upstream.
This patch changes iscsit_check_dataout_hdr() to dump the incoming
Data-Out payload when the received ITT is not associated with a
WRITE, instead of calling iscsit_reject_cmd() for the non WRITE
ITT descriptor.
This addresses a bug where an initiator sending an Data-Out for
an ITT associated with a READ would end up generating a reject
for the READ, eventually resulting in list corruption.
Reported-by: Santosh Kulkarni <santosh.kulkarni@calsoftinc.com>
Reported-by: Arshad Hussain <arshad.hussain@calsoftinc.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/iscsi/iscsi_target.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 72663ba228d..799f84e686b 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -1313,7 +1313,7 @@ iscsit_check_dataout_hdr(struct iscsi_conn *conn, unsigned char *buf, if (cmd->data_direction != DMA_TO_DEVICE) { pr_err("Command ITT: 0x%08x received DataOUT for a" " NON-WRITE command.\n", cmd->init_task_tag); - return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf); + return iscsit_dump_data_payload(conn, payload_length, 1); } se_cmd = &cmd->se_cmd; iscsit_mod_dataout_timer(cmd); |