diff options
| author | John Snow <jsnow@redhat.com> | 2016-10-27 12:07:00 -0400 |
|---|---|---|
| committer | Jeff Cody <jcody@redhat.com> | 2016-11-01 08:04:56 -0400 |
| commit | c87621ea68e37b87dde82d1da80f9f8d2e13ffae (patch) | |
| tree | b4c1a4c2bb03bd05c80017a54d5fbc7e55403034 /tests | |
| parent | 0df4ba58631772dd391314c1119863b574ebbaf9 (diff) | |
| download | qemu-c87621ea68e37b87dde82d1da80f9f8d2e13ffae.tar.gz qemu-c87621ea68e37b87dde82d1da80f9f8d2e13ffae.tar.bz2 qemu-c87621ea68e37b87dde82d1da80f9f8d2e13ffae.zip | |
blockjobs: split interface into public/private, Part 1
To make it a little more obvious which functions are intended to be
public interface and which are intended to be for use only by jobs
themselves, split the interface into "public" and "private" files.
Convert blockjobs (e.g. block/backup) to using the private interface.
Leave blockdev and others on the public interface.
There are remaining uses of private state by qemu-img, and several
cases in blockdev.c and block/io.c where we grab job->blk for the
purposes of acquiring an AIOContext.
These will be corrected in future patches.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1477584421-1399-7-git-send-email-jsnow@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-blockjob-txn.c | 2 | ||||
| -rw-r--r-- | tests/test-blockjob.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c index b79e0c68e1..f9afc3be41 100644 --- a/tests/test-blockjob-txn.c +++ b/tests/test-blockjob-txn.c @@ -13,7 +13,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/main-loop.h" -#include "block/blockjob.h" +#include "block/blockjob_int.h" #include "sysemu/block-backend.h" typedef struct { diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c index 18bf85017a..60b78a3342 100644 --- a/tests/test-blockjob.c +++ b/tests/test-blockjob.c @@ -13,7 +13,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/main-loop.h" -#include "block/blockjob.h" +#include "block/blockjob_int.h" #include "sysemu/block-backend.h" static const BlockJobDriver test_block_job_driver = { |