diff options
author | Eric Blake <eblake@redhat.com> | 2015-05-04 09:05:36 -0600 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2015-05-05 18:39:02 +0200 |
commit | a7f5966b297330f6492020019544ae87c45d699b (patch) | |
tree | 45224ce83f62a85570c12dfcd09ae22293b06123 /tests/qapi-schema/escape-too-short.json | |
parent | 363b4262a10a52f6d7ac1073bab5e6648da4051b (diff) | |
download | qemu-a7f5966b297330f6492020019544ae87c45d699b.tar.gz qemu-a7f5966b297330f6492020019544ae87c45d699b.tar.bz2 qemu-a7f5966b297330f6492020019544ae87c45d699b.zip |
qapi: Support (subset of) \u escapes in strings
The handling of \ inside QAPI strings was less than ideal, and
really only worked JSON's \/, \\, \", and our extension of \'
(an obvious extension, when you realize we use '' instead of ""
for strings). For other things, like '\n', it resulted in a
literal 'n' instead of a newline.
Of course, at the moment, we really have no use for escaped
characters, as QAPI has to map to C identifiers, and we currently
support ASCII only for that. But down the road, we may add
support for default values for string parameters to a command
or struct; if that happens, it would be nice to correctly support
all JSON escape sequences, such as \n or \uXXXX. This gets us
closer, by supporting Unicode escapes in the ASCII range.
Since JSON does not require \OCTAL or \xXX escapes, and our QMP
implementation does not understand them either, I intentionally
reject it here, but it would be an easy addition if we desired it.
Likewise, intentionally refusing the NUL byte means we don't have
to worry about C strings being shorter than the qapi input.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/qapi-schema/escape-too-short.json')
-rw-r--r-- | tests/qapi-schema/escape-too-short.json | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/qapi-schema/escape-too-short.json b/tests/qapi-schema/escape-too-short.json new file mode 100644 index 0000000000..6cb1dec8f7 --- /dev/null +++ b/tests/qapi-schema/escape-too-short.json @@ -0,0 +1,3 @@ +# the \u escape requires 4 hex digits +# { 'command': 'a' } +{ 'command': '\u61' } |