summaryrefslogtreecommitdiff
path: root/target-i386
diff options
context:
space:
mode:
authorRichard Henderson <rth@twiddle.net>2013-11-02 08:32:39 -1000
committerRichard Henderson <rth@twiddle.net>2014-01-07 11:36:31 -0800
commit4b1fe0671f5f9324b570c5ec165c67b36b05e7d2 (patch)
treece8eb4ac732aa87c905e08963394c97b48341e35 /target-i386
parentc8fbc479674d00a8f9dd63f9a9d4978c4c4b96d9 (diff)
downloadqemu-4b1fe0671f5f9324b570c5ec165c67b36b05e7d2.tar.gz
qemu-4b1fe0671f5f9324b570c5ec165c67b36b05e7d2.tar.bz2
qemu-4b1fe0671f5f9324b570c5ec165c67b36b05e7d2.zip
target-i386: Tidy movsl
Always perform a sign-extending load. In the extremely unlikely case that we've used an 0x66 prefix, the extension to 64-bits is unnecessary but not wrong; the store will still examine only 16 bits. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Richard Henderson <rth@twiddle.net>
Diffstat (limited to 'target-i386')
-rw-r--r--target-i386/translate.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/target-i386/translate.c b/target-i386/translate.c
index f3baa4d118..0a414c424c 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -7747,11 +7747,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
gen_op_mov_reg_T0(d_ot, reg);
} else {
gen_lea_modrm(env, s, modrm, &reg_addr, &offset_addr);
- if (d_ot == MO_64) {
- gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0);
- } else {
- gen_op_ld_v(s, MO_32, cpu_T[0], cpu_A0);
- }
+ gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0);
gen_op_mov_reg_T0(d_ot, reg);
}
} else