diff options
| author | Igor Mammedov <imammedo@redhat.com> | 2016-02-26 14:59:27 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2016-03-11 16:59:12 +0200 |
| commit | ed2ef10c0ce2feed9647b9f5c3df624078dd2dd0 (patch) | |
| tree | 2e21ad283bda4ba78f4f28a3be16e7469ac8b54c /hw | |
| parent | adcb89d55d70dee9994465385bbf6e885412cc1b (diff) | |
| download | qemu-ed2ef10c0ce2feed9647b9f5c3df624078dd2dd0.tar.gz qemu-ed2ef10c0ce2feed9647b9f5c3df624078dd2dd0.tar.bz2 qemu-ed2ef10c0ce2feed9647b9f5c3df624078dd2dd0.zip | |
pc: acpi: clarify why possible LAPIC entries must be present in MADT
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/i386/acpi-build.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 8736917f0b..0a5acb3828 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -360,6 +360,12 @@ build_madt(GArray *table_data, GArray *linker, PCMachineState *pcms) if (apic_ids->cpus[i].cpu != NULL) { apic->flags = cpu_to_le32(1); } else { + /* ACPI spec says that LAPIC entry for non present + * CPU may be omitted from MADT or it must be marked + * as disabled. However omitting non present CPU from + * MADT breaks hotplug on linux. So possible CPUs + * should be put in MADT but kept disabled. + */ apic->flags = cpu_to_le32(0); } } |