summaryrefslogtreecommitdiff
path: root/hw/serial.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2009-10-07 01:16:01 +0200
committerAnthony Liguori <aliguori@us.ibm.com>2009-10-07 08:54:55 -0500
commit5c17ca2505197c56d0097c66a4e5bda4d6f32fb6 (patch)
tree011adae1a2f9ce724c92629bd99b78507a7d97ec /hw/serial.c
parentdde8bbb44de41ea68f9bede0a6a778ce046b2bcf (diff)
downloadqemu-5c17ca2505197c56d0097c66a4e5bda4d6f32fb6.tar.gz
qemu-5c17ca2505197c56d0097c66a4e5bda4d6f32fb6.tar.bz2
qemu-5c17ca2505197c56d0097c66a4e5bda4d6f32fb6.zip
Clean up test for qdev_init() failure
Some callers test for != 0, some for < 0. Normalize to < 0. Patchworks-ID: 35171 Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/serial.c')
-rw-r--r--hw/serial.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/serial.c b/hw/serial.c
index e044923101..eb14f11ba1 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -759,7 +759,7 @@ SerialState *serial_isa_init(int index, CharDriverState *chr)
qdev_prop_set_uint32(&dev->qdev, "iobase", isa_serial_io[index]);
qdev_prop_set_uint32(&dev->qdev, "irq", isa_serial_irq[index]);
qdev_prop_set_chr(&dev->qdev, "chardev", chr);
- if (qdev_init(&dev->qdev) != 0)
+ if (qdev_init(&dev->qdev) < 0)
return NULL;
return &DO_UPCAST(ISASerialState, dev, dev)->state;
}