diff options
author | Aurelien Jarno <aurelien@aurel32.net> | 2011-01-06 22:43:13 +0100 |
---|---|---|
committer | Aurelien Jarno <aurelien@aurel32.net> | 2011-01-10 10:56:25 +0100 |
commit | 8aaf42ed0f203da63860b0a3ab3ff2bdfe9b4cb0 (patch) | |
tree | ab1d3ada2c1fa6ee1b429d9c56676e9323416fc8 /hw/pc_piix.c | |
parent | 102c29769fa7cd564053ea41735395f428b6f197 (diff) | |
download | qemu-8aaf42ed0f203da63860b0a3ab3ff2bdfe9b4cb0.tar.gz qemu-8aaf42ed0f203da63860b0a3ab3ff2bdfe9b4cb0.tar.bz2 qemu-8aaf42ed0f203da63860b0a3ab3ff2bdfe9b4cb0.zip |
slirp: fix unaligned access in bootp code
Slirp code tries to be smart an avoid data copy by using pointer to
the data. This solution leads to unaligned access, in this case
preq_addr, which is a 32-bit long structure. There is no real point
of avoiding data copy in a such case, as the value itself is smaller
or the same size as a pointer.
The patch replaces pointers to the preq_addr structure by the strcture
itself, and use the address 0.0.0.0 if no address has been requested
(this is not a valid address in such a request). It compares it with
htonl(0L) for correctness reasons, in case a code checker look for such
mistakes. It also uses memcpy() for copying the data, which takes care
of alignement issues.
This fixes an unaligned access on IA64 host while requesting a DHCP
address.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Diffstat (limited to 'hw/pc_piix.c')
0 files changed, 0 insertions, 0 deletions