diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2016-06-17 17:01:21 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-06-29 14:03:46 +0200 |
| commit | f62efcacfab114d0fae016dd9c0cd500f70dd70d (patch) | |
| tree | 905d477e91f9461b40630d60d1639ef2db04b22f /hw/isa | |
| parent | f2dd8ebdf40e3cf3863b9022ccb3c3489c2d1c76 (diff) | |
| download | qemu-f62efcacfab114d0fae016dd9c0cd500f70dd70d.tar.gz qemu-f62efcacfab114d0fae016dd9c0cd500f70dd70d.tar.bz2 qemu-f62efcacfab114d0fae016dd9c0cd500f70dd70d.zip | |
ich9: call ich9_lpc_update_pic for disabled pirqs
An asserted pirq can be disabled and the corresponding GSIs
should then go down to 0. However, because of the conditional in
ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1.
Reviewed-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/isa')
| -rw-r--r-- | hw/isa/lpc_ich9.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index c1a4f1b34c..f7aed231e6 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq) ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis); assert(pic_irq < ICH9_LPC_PIC_NUM_PINS); - if (pic_dis) { - return; - } ich9_lpc_update_pic(lpc, pic_irq); } |