diff options
| author | Glauber Costa <glommer@redhat.com> | 2009-11-05 16:05:15 -0200 |
|---|---|---|
| committer | Blue Swirl <blauwirbel@gmail.com> | 2009-11-07 08:06:58 +0000 |
| commit | c169998802505c244b8bcad562633f29de7d74a4 (patch) | |
| tree | 70c88e1184c0b4e77b1b4997250cc418d07cde8b /hw/ide | |
| parent | cae334cd6b2aed62a2af82314da1b9eab06824d5 (diff) | |
| download | qemu-c169998802505c244b8bcad562633f29de7d74a4.tar.gz qemu-c169998802505c244b8bcad562633f29de7d74a4.tar.bz2 qemu-c169998802505c244b8bcad562633f29de7d74a4.zip | |
v3: don't call reset functions on cpu initialization
There is absolutely no need to call reset functions when initializing
devices. Since we are already registering them, calling qemu_system_reset()
should suffice. Actually, it is what happens when we reboot the machine,
and using the same process instead of a special case semantics will even
allow us to find bugs easier.
Furthermore, the fact that we initialize things like the cpu quite early,
leads to the need to introduce synchronization stuff like qemu_system_cond.
This patch removes it entirely. All we need to do is call qemu_system_reset()
only when we're already sure the system is up and running
I tested it with qemu (with and without io-thread) and qemu-kvm, and it
seems to be doing okay - although qemu-kvm uses a slightly different patch.
[ v2: user mode still needs cpu_reset, so put it in ifdef. ]
[ v3: leave qemu_system_cond for now. ]
Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Diffstat (limited to 'hw/ide')
| -rw-r--r-- | hw/ide/piix.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/ide/piix.c b/hw/ide/piix.c index a17bf5951c..60b37a36a5 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -120,7 +120,6 @@ static int pci_piix_ide_initfn(PCIIDEState *d) pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type qemu_register_reset(piix3_reset, d); - piix3_reset(d); pci_register_bar(&d->dev, 4, 0x10, PCI_ADDRESS_SPACE_IO, bmdma_map); |