summaryrefslogtreecommitdiff
path: root/hw/char/sclpconsole.c
diff options
context:
space:
mode:
authorMaxime Coquelin <maxime.coquelin@redhat.com>2016-12-14 17:30:35 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2016-12-15 07:35:19 +0000
commit66d1c4c19faff83e36075c7b61053d060a8ffc50 (patch)
treed85a1575a0856dcc9e1cc8ba1f0446afd647b754 /hw/char/sclpconsole.c
parentd70678a5388fb6340d018f51b863ec9712b905da (diff)
downloadqemu-66d1c4c19faff83e36075c7b61053d060a8ffc50.tar.gz
qemu-66d1c4c19faff83e36075c7b61053d060a8ffc50.tar.bz2
qemu-66d1c4c19faff83e36075c7b61053d060a8ffc50.zip
virtio-pci: Fix cross-version migration with older machines
This patch fixes a cross-version migration regression introduced by commit d1b4259f ("virtio-bus: Plug devices after features are negotiated"). The problem is encountered when host's vhost backend does not support VIRTIO_F_VERSION_1, and migration is initiated from a v2.7 or prior machine with virtio-pci modern capabilities enabled to a v2.8 machine. In this case, modern capabilities get exposed to the guest by the source, whereas the target will detect version 1 is not supported so will only expose legacy capabilities. The problem is fixed by introducing a new "x-ignore-backend-features" property, which is set in v2.7 and prior compatibility modes. Doing this, v2.7 machine keeps its broken behaviour (enabling modern while version is not supported), and newer machines will behave correctly. Reported-by: Michael Roth <mdroth@linux.vnet.ibm.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Tested-by: Michael Roth <mdroth@linux.vnet.ibm.com> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Message-id: 20161214163035.3297-1-maxime.coquelin@redhat.com Suggested-by: Stefan Hajnoczi <stefanha@redhat.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Tested-by: Michael Roth <mdroth@linux.vnet.ibm.com> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'hw/char/sclpconsole.c')
0 files changed, 0 insertions, 0 deletions