diff options
author | Markus Armbruster <armbru@redhat.com> | 2016-05-31 10:31:38 +0200 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2016-06-20 16:36:29 +0200 |
commit | da002526ac30f679b0c797b0d71102dcdf200fe6 (patch) | |
tree | 4d1556214934b773b7b3f36cc2010c41deb3b23e | |
parent | 5edbd4e30426d3a0d712510b2509a521e35192b1 (diff) | |
download | qemu-da002526ac30f679b0c797b0d71102dcdf200fe6.tar.gz qemu-da002526ac30f679b0c797b0d71102dcdf200fe6.tar.bz2 qemu-da002526ac30f679b0c797b0d71102dcdf200fe6.zip |
vl: Error messages need to go to stderr, fix some
We print a few fatal error messages to stdout instead of stderr.
Reproducer:
$ qemu-system-x86_64 -g 1024x768
Option g not supported for this target
$ qemu-system-x86_64 -g 1024x768 >/dev/null
Fix by printing them with error_report(). This also improves the messages.
The above one becomes
qemu-system-x86_64: -g 1024x768: Option not supported for this target
Reported-by: Tobi {github.com/tobimensch}
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1464683498-28779-1-git-send-email-armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
-rw-r--r-- | vl.c | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -3068,7 +3068,7 @@ int main(int argc, char **argv, char **envp) popt = lookup_opt(argc, argv, &optarg, &optind); if (!(popt->arch_mask & arch_type)) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } switch(popt->index) { @@ -3846,21 +3846,21 @@ int main(int argc, char **argv, char **envp) break; case QEMU_OPTION_xen_domid: if (!(xen_available())) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } xen_domid = atoi(optarg); break; case QEMU_OPTION_xen_create: if (!(xen_available())) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } xen_mode = XEN_CREATE; break; case QEMU_OPTION_xen_attach: if (!(xen_available())) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } xen_mode = XEN_ATTACH; |