summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBlue Swirl <blauwirbel@gmail.com>2010-08-20 21:04:37 +0000
committerBlue Swirl <blauwirbel@gmail.com>2010-08-20 21:04:37 +0000
commitcc597832119dd1504f1c1536bb5f903d8970af2a (patch)
tree190a8de8e8674c1013b106b77ba7b93d2ec34bf9
parent66fe09eebb813b79e14279df11d723b433a973fb (diff)
downloadqemu-cc597832119dd1504f1c1536bb5f903d8970af2a.tar.gz
qemu-cc597832119dd1504f1c1536bb5f903d8970af2a.tar.bz2
qemu-cc597832119dd1504f1c1536bb5f903d8970af2a.zip
Replace qemu_malloc + memset with qemu_mallocz
Replace a qemu_malloc call, followed by a memset, with qemu_mallocz. Found with this Coccinelle semantic patch, adapted from Coccinelle test package rule 94: @@ type T; expression x; expression E; @@ - x = (T)qemu_malloc(E) + x = qemu_mallocz(E) ... ( - memset(x,0,E); | - memset(x,0,sizeof(*x)); ) Some files (tests/*) had to be filtered out. Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
-rw-r--r--hw/sh_intc.c3
-rw-r--r--hw/virtio-9p.c3
2 files changed, 2 insertions, 4 deletions
diff --git a/hw/sh_intc.c b/hw/sh_intc.c
index da36d32b1d..d3f5ea57d5 100644
--- a/hw/sh_intc.c
+++ b/hw/sh_intc.c
@@ -431,9 +431,8 @@ int sh_intc_init(struct intc_desc *desc,
desc->nr_prio_regs = nr_prio_regs;
i = sizeof(struct intc_source) * nr_sources;
- desc->sources = qemu_malloc(i);
+ desc->sources = qemu_mallocz(i);
- memset(desc->sources, 0, i);
for (i = 0; i < desc->nr_sources; i++) {
struct intc_source *source = desc->sources + i;
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index f8c85c3d28..047c7ea4eb 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -1969,9 +1969,8 @@ static void v9fs_wstat_post_chown(V9fsState *s, V9fsWstatState *vs, int err)
end = old_name;
}
- new_name = qemu_malloc(end - old_name + vs->v9stat.name.size + 1);
+ new_name = qemu_mallocz(end - old_name + vs->v9stat.name.size + 1);
- memset(new_name, 0, end - old_name + vs->v9stat.name.size + 1);
memcpy(new_name, old_name, end - old_name);
memcpy(new_name + (end - old_name), vs->v9stat.name.data,
vs->v9stat.name.size);