diff options
| author | Namhyung Kim <namhyung.kim@lge.com> | 2012-04-26 14:15:20 +0900 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-05-02 15:24:14 -0300 |
| commit | 770a34a38b74982724dbb099225944b415f90281 (patch) | |
| tree | 84a55ee3eb28ca2319b33a982e6f61619a502dde /tools | |
| parent | b809ac100e2f12ebf1b58ff522dba15651a77d27 (diff) | |
| download | kernel-common-770a34a38b74982724dbb099225944b415f90281.tar.gz kernel-common-770a34a38b74982724dbb099225944b415f90281.tar.bz2 kernel-common-770a34a38b74982724dbb099225944b415f90281.zip | |
perf tools: Check more combinations of PID/TID, UID and CPU switches
There were some combinations of these switches that are not so
appropriate IMHO.
Since there are implicit priorities between them and they worked well
anyway, but it ends up opening useless duplicated events.
For example, 'perf stat -t <pid> -a' will open multiple events for the
thread instead of one.
Add explicit checks and warn user in perf_target__validate().
Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1335417327-11796-7-git-send-email-namhyung.kim@lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/usage.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tools/perf/util/usage.c b/tools/perf/util/usage.c index 0a1a885a5914..228f0a558872 100644 --- a/tools/perf/util/usage.c +++ b/tools/perf/util/usage.c @@ -132,4 +132,18 @@ void perf_target__validate(struct perf_target *target) sleep(1); target->uid_str = NULL; } + + /* UID and CPU are mutually exclusive */ + if (target->uid_str && target->cpu_list) { + ui__warning("UID switch overriding CPU\n"); + sleep(1); + target->cpu_list = NULL; + } + + /* PID/UID and SYSTEM are mutually exclusive */ + if ((target->tid || target->uid_str) && target->system_wide) { + ui__warning("PID/TID/UID switch overriding CPU\n"); + sleep(1); + target->system_wide = false; + } } |