summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2013-09-05 09:22:03 +0530
committerMark Brown <broonie@linaro.org>2013-09-17 00:28:44 +0100
commitcab87f062d0c57c9734257e4079ced489a3189b1 (patch)
treec8229c08b3a7caacfdf285f4d407664bc749ac87
parent42141f22e32a452b02b3dc8764d93223505e1c10 (diff)
downloadkernel-common-cab87f062d0c57c9734257e4079ced489a3189b1.tar.gz
kernel-common-cab87f062d0c57c9734257e4079ced489a3189b1.tar.bz2
kernel-common-cab87f062d0c57c9734257e4079ced489a3189b1.zip
regulator: Remove redundant NULL assignment
NULL assignment corrupts the error pointer and is not necessary. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r--drivers/regulator/max77686.c1
-rw-r--r--drivers/regulator/max77693.c1
-rw-r--r--drivers/regulator/max8997.c1
3 files changed, 0 insertions, 3 deletions
diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
index de5b30ea823c..ae001ccf26f4 100644
--- a/drivers/regulator/max77686.c
+++ b/drivers/regulator/max77686.c
@@ -483,7 +483,6 @@ static int max77686_pmic_probe(struct platform_device *pdev)
if (IS_ERR(max77686->rdev[i])) {
dev_err(&pdev->dev,
"regulator init failed for %d\n", i);
- max77686->rdev[i] = NULL;
return PTR_ERR(max77686->rdev[i]);
}
}
diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c
index 2054ae1c496e..feb20bf4ccab 100644
--- a/drivers/regulator/max77693.c
+++ b/drivers/regulator/max77693.c
@@ -271,7 +271,6 @@ static int max77693_pmic_probe(struct platform_device *pdev)
if (IS_ERR(max77693_pmic->rdev[i])) {
dev_err(max77693_pmic->dev,
"Failed to initialize regulator-%d\n", id);
- max77693_pmic->rdev[i] = NULL;
return PTR_ERR(max77693_pmic->rdev[i]);
}
}
diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c
index 059e8ed7fa24..bcd2488d1252 100644
--- a/drivers/regulator/max8997.c
+++ b/drivers/regulator/max8997.c
@@ -1209,7 +1209,6 @@ static int max8997_pmic_probe(struct platform_device *pdev)
if (IS_ERR(rdev[i])) {
dev_err(max8997->dev, "regulator init failed for %d\n",
id);
- rdev[i] = NULL;
return PTR_ERR(rdev[i]);
}
}