diff options
| author | Tejun Heo <tj@kernel.org> | 2008-08-29 16:27:43 +0200 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2008-09-08 12:15:38 -0400 |
| commit | 9c2676b61a5a4b6d99e65fb2f438fb3914302eda (patch) | |
| tree | b52a7d20fbebee27edefac35ff5139c0daef0df2 | |
| parent | 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 (diff) | |
| download | kernel-common-9c2676b61a5a4b6d99e65fb2f438fb3914302eda.tar.gz kernel-common-9c2676b61a5a4b6d99e65fb2f438fb3914302eda.tar.bz2 kernel-common-9c2676b61a5a4b6d99e65fb2f438fb3914302eda.zip | |
libata-sff: kill spurious WARN_ON() in ata_hsm_move()
On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
AC_ERR_HSM is not set. PHY events may trigger HSM_ST_ERR with other
error codes and, with or without it, there just isn't much reason to
do WARN_ON() on it. Even if error code is not set there, core EH
logic won't have any problem dealing with the error condition.
OSDL bz#11065 reports this problem.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| -rw-r--r-- | drivers/ata/libata-sff.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 304fdc6f1dc2..2a4c516894f0 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -1315,11 +1315,6 @@ fsm_start: break; case HSM_ST_ERR: - /* make sure qc->err_mask is available to - * know what's wrong and recover - */ - WARN_ON(!(qc->err_mask & (AC_ERR_DEV | AC_ERR_HSM))); - ap->hsm_task_state = HSM_ST_IDLE; /* complete taskfile transaction */ |