summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2014-01-28 16:01:04 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-05-06 07:59:27 -0700
commit6cd9ecd59521d89c087c561680ae272dcc3a5059 (patch)
tree853e636d5cdfee1316a68a8dd1d03f1781d41788
parent83b19121522b00aa21b5342a0c2e1e019bd1d5f2 (diff)
downloadkernel-common-6cd9ecd59521d89c087c561680ae272dcc3a5059.tar.gz
kernel-common-6cd9ecd59521d89c087c561680ae272dcc3a5059.tar.bz2
kernel-common-6cd9ecd59521d89c087c561680ae272dcc3a5059.zip
nfsd4: session needs room for following op to error out
commit 4c69d5855a16f7378648c5733632628fa10431db upstream. Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/nfsd/nfs4proc.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 82189b208af3..b9048e5e349e 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1359,6 +1359,12 @@ nfsd4_proc_compound(struct svc_rqst *rqstp,
/* If op is non-idempotent */
if (opdesc->op_flags & OP_MODIFIES_SOMETHING) {
plen = opdesc->op_rsize_bop(rqstp, op);
+ /*
+ * If there's still another operation, make sure
+ * we'll have space to at least encode an error:
+ */
+ if (resp->opcnt < args->opcnt)
+ plen += COMPOUND_ERR_SLACK_SPACE;
op->status = nfsd4_check_resp_size(resp, plen);
}