diff options
| author | Namhyung Kim <namhyung@gmail.com> | 2010-10-26 14:22:43 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-26 16:52:15 -0700 |
| commit | 571428be550fbe37160596995e96ad398873fcbd (patch) | |
| tree | eddfb410db3ae0260f5a0a5d4301869ba02779e9 | |
| parent | 562f5e638de4ef451226552fe8dd7847bacea24e (diff) | |
| download | kernel-common-571428be550fbe37160596995e96ad398873fcbd.tar.gz kernel-common-571428be550fbe37160596995e96ad398873fcbd.tar.bz2 kernel-common-571428be550fbe37160596995e96ad398873fcbd.zip | |
kernel/user.c: add lock release annotation on free_user()
free_user() releases uidhash_lock but was missing annotation. Add it.
This removes following sparse warnings:
include/linux/spinlock.h:339:9: warning: context imbalance in 'free_user' - unexpected unlock
kernel/user.c:120:6: warning: context imbalance in 'free_uid' - wrong count at exit
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Dhaval Giani <dhaval.giani@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | kernel/user.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/user.c b/kernel/user.c index 7e72614b736d..2c7d8d5914b1 100644 --- a/kernel/user.c +++ b/kernel/user.c @@ -91,6 +91,7 @@ static struct user_struct *uid_hash_find(uid_t uid, struct hlist_head *hashent) * upon function exit. */ static void free_user(struct user_struct *up, unsigned long flags) + __releases(&uidhash_lock) { uid_hash_remove(up); spin_unlock_irqrestore(&uidhash_lock, flags); |