summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrantisek Sumsal <frantisek@sumsal.cz>2019-07-30 21:22:10 +0200
committerYu Watanabe <watanabe.yu+github@gmail.com>2019-07-31 09:45:26 +0900
commit4967da2dbc4870f5af9acbb99453d6f4802fb1d3 (patch)
tree8e6f56928b78ac29bfe7fa66bdd9e1620bd6a8af
parent417b82e1c341946d277383471f2972b7227061ff (diff)
downloadsystemd-4967da2dbc4870f5af9acbb99453d6f4802fb1d3.tar.gz
systemd-4967da2dbc4870f5af9acbb99453d6f4802fb1d3.tar.bz2
systemd-4967da2dbc4870f5af9acbb99453d6f4802fb1d3.zip
test-execute: skip test_exec_systemcallfilter_system under ASan
This particular test case keeps intermittently failing due to crashing LSan when running under clang+ASan. Generally, sanitizers don't like seccomp filters, so the best option here is to just switch this test off for this scenario.
-rw-r--r--src/test/test-execute.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/test/test-execute.c b/src/test/test-execute.c
index e308d75a56..435ab39cd2 100644
--- a/src/test/test-execute.c
+++ b/src/test/test-execute.c
@@ -471,7 +471,12 @@ static void test_exec_restrictnamespaces(Manager *m) {
}
static void test_exec_systemcallfilter_system(Manager *m) {
-#if HAVE_SECCOMP
+/* Skip this particular test case when running under ASan, as
+ * LSan intermittently segfaults when accessing memory right
+ * after the test finishes. Generally, ASan & LSan don't like
+ * the seccomp stuff.
+ */
+#if HAVE_SECCOMP && !HAS_FEATURE_ADDRESS_SANITIZER
if (!is_seccomp_available()) {
log_notice("Seccomp not available, skipping %s", __func__);
return;