1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
|
# vim:sw=4:et
#############################################################################
# File : CheckAlternativesGhostFiles.py
# Package : rpmlint
# Author : Michal Vyskocil
# Purpose : Check if files used by update-alternatives are marked as %ghost
#############################################################################
from Filter import *
import AbstractCheck
import rpm
class CheckAlternativesGhostFiles(AbstractCheck.AbstractCheck):
INSTALL="--install"
SLAVE="--slave"
def __init__(self):
AbstractCheck.AbstractCheck.__init__(self, "CheckAlternativesGhostFiles")
@classmethod
def read_ghost_files(cls, script):
ghost_files = []
if not script or not 'update-alternatives' in script:
return ghost_files
for command in ( \
c.replace('\\\n', '').strip() \
for c in script.split('update-alternatives') \
if cls.INSTALL in c):
#parse install
command_args = []
for arg in command.split(None):
if not arg.startswith("--"):
command_args.append(arg)
ghost_files.append(command_args[0])
if cls.SLAVE in command:
for sc in ( \
c.strip() \
for c in command[command.index(cls.SLAVE):].split(cls.SLAVE) \
if c.strip() != ''):
xs = sc.split(None, 2)
ghost_files.append(xs[0])
return ghost_files
def check(self, pkg):
if pkg.isSource():
return
alt_files = []
for script in (pkg.header[tag] for tag in (rpm.RPMTAG_POSTIN, rpm.RPMTAG_PREIN, rpm.RPMTAG_POSTTRANS)):
alt_files.extend(self.read_ghost_files(script))
files = pkg.files()
ghost_files = pkg.ghostFiles()
for af in (af for af in alt_files if not af in ghost_files):
if af in files:
printWarning(pkg, 'generic-name-not-marked-as-ghost %s' % (af))
else:
printWarning(pkg, 'generic-name-not-in-filelist %s' % af)
check=CheckAlternativesGhostFiles()
if Config.info:
addDetails(
'generic-name-not-marked-as-ghost',
'''The update-alternatives generic name is not marked as a ghost in the %files section.
This causes problems during update. Mark it as a %ghost in %files section.''',
'generic-name-not-in-filelist',
'''The update-alternatives generic name is not in a filelist of package.
Add it to list marked as %ghost. Note: this error will be raised,
if you use a hash ($) in file name, use rpm macros in spec file instead.''',
)
|
