rpmlib.h mass eviction

- explicitly include what's really needed instead
- document remaining uses

38 files changed, 46 insertions, 31 deletions

diff --git a/lib/depends.c b/lib/depends.c
index 87f381efd..eccb3a9eb 100644
--- a/lib/depends.c
+++ b/lib/depends.c
@@ -6,6 +6,8 @@
 
 #include <rpm/rpmcli.h>		/* XXX rpmcliPackagesTotal */
 
+#include <rpm/rpmlib.h>			/* rpmVersionCompare, rpmlib provides */
+#include <rpm/rpmtag.h>
 #include <rpm/rpmmacro.h>		/* XXX rpmExpand("%{_dependency_whiteout}" */
 #include <rpm/rpmlog.h>
 
diff --git a/lib/formats.c b/lib/formats.c
index 90ea4d357..98eee4553 100644
--- a/lib/formats.c
+++ b/lib/formats.c
@@ -4,7 +4,8 @@
 
 #include "system.h"
 #include "rpmio/digest.h"
-#include <rpm/rpmlib.h>
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* rpmGetFilesystem*() */
 #include <rpm/rpmds.h>
 #include <rpm/rpmmacro.h>	/* XXX for %_i18ndomains */
 
diff --git a/lib/fs.c b/lib/fs.c
index 9c8055117..1663ee252 100644
--- a/lib/fs.c
+++ b/lib/fs.c
@@ -3,7 +3,7 @@
  */
 
 #include "system.h"
-#include <rpm/rpmlib.h>
+#include <rpm/rpmlib.h>		/* rpmGetFilesystem*() prototypes */
 #include <rpm/rpmfileutil.h>	/* for rpmGetPath */
 #include <rpm/rpmlog.h>
 #include "debug.h"
diff --git a/lib/fsm.c b/lib/fsm.c
index e5b739a49..7f51659c4 100644
--- a/lib/fsm.c
+++ b/lib/fsm.c
@@ -6,7 +6,6 @@
 #include "system.h"
 
 #include "rpmio/rpmio_internal.h"	/* fdGet/SetCpioPos, fdInit/FiniDigest */
-#include <rpm/rpmlib.h>
 
 #include "lib/cpio.h"
 
diff --git a/lib/idtx.c b/lib/idtx.c
index dfa898edc..7e9c68164 100644
--- a/lib/idtx.c
+++ b/lib/idtx.c
@@ -1,7 +1,8 @@
 #include "system.h"
 
 #include <rpm/idtx.h>
-#include <rpm/rpmlib.h>
+#include <rpm/rpmlib.h>		/* rpmReadPackageFile */
+#include <rpm/rpmtag.h>
 #include <rpm/rpmdb.h>
 #include <rpm/rpmts.h>
 #include <rpm/rpmfileutil.h>
diff --git a/lib/legacy.c b/lib/legacy.c
index 704af5aaa..86a205ba2 100644
--- a/lib/legacy.c
+++ b/lib/legacy.c
@@ -4,7 +4,7 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
+#include <rpm/rpmtag.h>
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmstring.h>
 #include <rpm/rpmfi.h>
diff --git a/lib/manifest.c b/lib/manifest.c
index 7c89db811..7e5d1964b 100644
--- a/lib/manifest.c
+++ b/lib/manifest.c
@@ -4,7 +4,6 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
 #include <rpm/rpmlog.h>
 #include <rpm/rpmfileutil.h>
 
diff --git a/lib/misc.c b/lib/misc.c
index 9a01bd5fc..2a8abfd35 100644
--- a/lib/misc.c
+++ b/lib/misc.c
@@ -9,7 +9,6 @@ const char * RPMVERSION = VERSION;
 
 #include <rpm/rpmurl.h>
 #include <rpm/rpmmacro.h>	/* XXX for rpmGetPath */
-#include <rpm/rpmlib.h>
 #include <rpm/rpmlog.h>
 #include "lib/misc.h"
 #include "debug.h"
diff --git a/lib/misc.h b/lib/misc.h
index c860ab892..68815749e 100644
--- a/lib/misc.h
+++ b/lib/misc.h
@@ -7,6 +7,7 @@
  */
 
 #include <string.h>
+#include <rpm/rpmtypes.h>
 
 #ifdef __cplusplus
 extern "C" {
diff --git a/lib/package.c b/lib/package.c
index 8fd94f62a..1e316531e 100644
--- a/lib/package.c
+++ b/lib/package.c
@@ -8,8 +8,8 @@
 
 #include "rpmio/digest.h"
 #include "rpmio/rpmio_internal.h"	/* fd*Digest(), fd stats */
-#include <rpm/rpmlib.h>
 
+#include <rpm/rpmlib.h>			/* XXX RPMSIGTAG, other sig stuff */
 #include <rpm/rpmts.h>
 
 #include "lib/legacy.h"	/* XXX legacyRetrofit() */
diff --git a/lib/poptALL.c b/lib/poptALL.c
index 77b439d56..feb94c052 100644
--- a/lib/poptALL.c
+++ b/lib/poptALL.c
@@ -7,6 +7,7 @@
 const char *__progname;
 
 #include <rpm/rpmcli.h>
+#include <rpm/rpmlib.h>		/* rpmEVR, rpmReadConfigFiles etc */
 #include <rpm/rpmgi.h>
 #include <rpm/rpmlog.h>
 #include <rpm/rpmstring.h>
diff --git a/lib/psm.c b/lib/psm.c
index d271fead3..1b2ee970e 100644
--- a/lib/psm.c
+++ b/lib/psm.c
@@ -5,7 +5,7 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
+#include <rpm/rpmlib.h>		/* rpmvercmp and others */
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmurl.h>
 #include "rpmio/rpmlua.h"
diff --git a/lib/query.c b/lib/query.c
index 0fb6bccd0..020b307cb 100644
--- a/lib/query.c
+++ b/lib/query.c
@@ -11,6 +11,7 @@
 
 #include <rpm/rpmcli.h>
 
+#include <rpm/rpmtag.h>
 #include <rpm/rpmdb.h>
 #include <rpm/rpmfi.h>
 
diff --git a/lib/rpmal.c b/lib/rpmal.c
index c2643af03..a0956cd7b 100644
--- a/lib/rpmal.c
+++ b/lib/rpmal.c
@@ -4,7 +4,6 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
 
 #include <rpm/rpmal.h>
 #include <rpm/rpmds.h>
diff --git a/lib/rpmchecksig.c b/lib/rpmchecksig.c
index d909faad7..3f47ab4ed 100644
--- a/lib/rpmchecksig.c
+++ b/lib/rpmchecksig.c
@@ -5,6 +5,7 @@
 
 #include "system.h"
 
+#include <rpm/rpmlib.h>			/* RPMSIGTAG & related */
 #include <rpm/rpmpgp.h>
 #include "rpmio/rpmio_internal.h"	/* for fd*Digest() */
 #include <rpm/rpmcli.h>
diff --git a/lib/rpmcli.h b/lib/rpmcli.h
index 49cd3b0af..64700e759 100644
--- a/lib/rpmcli.h
+++ b/lib/rpmcli.h
@@ -5,7 +5,8 @@
  * \file lib/rpmcli.h
  */
 
-#include <rpm/rpmlib.h>
+#include <popt.h>
+
 #include <rpm/rpmurl.h>
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmcallback.h>
diff --git a/lib/rpmds.c b/lib/rpmds.c
index 79720e618..84a859cc6 100644
--- a/lib/rpmds.c
+++ b/lib/rpmds.c
@@ -3,7 +3,8 @@
  */
 #include "system.h"
 
-#include <rpm/rpmlib.h>
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* rpmvercmp */
 #include <rpm/rpmstring.h>
 #include <rpm/rpmlog.h>
 
diff --git a/lib/rpmfi.c b/lib/rpmfi.c
index 657d334ba..6c5d78699 100644
--- a/lib/rpmfi.c
+++ b/lib/rpmfi.c
@@ -5,7 +5,6 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
 #include <rpm/rpmlog.h>
 
 #include "lib/cpio.h"	/* XXX CPIO_FOO */
diff --git a/lib/rpmfi_internal.h b/lib/rpmfi_internal.h
index 93658b2ce..095d2f555 100644
--- a/lib/rpmfi_internal.h
+++ b/lib/rpmfi_internal.h
@@ -1,6 +1,7 @@
 #ifndef _RPMFI_INTERNAL_H
 #define _RPMFI_INTERNAL_H
 
+#include <rpm/rpmtag.h>
 #include <rpm/rpmfi.h>
 #include "lib/fsm.h"		/* for FSM_t */
 
diff --git a/lib/rpmgi.c b/lib/rpmgi.c
index 34057981c..49e8bc544 100644
--- a/lib/rpmgi.c
+++ b/lib/rpmgi.c
@@ -3,7 +3,8 @@
  */
 #include "system.h"
 
-#include <rpm/rpmlib.h>
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* rpmReadPackageFile */
 #include <rpm/rpmte.h>		/* XXX rpmElementType */
 #include <rpm/rpmts.h>
 
diff --git a/lib/rpminstall.c b/lib/rpminstall.c
index 9c079cfed..02c6a5061 100644
--- a/lib/rpminstall.c
+++ b/lib/rpminstall.c
@@ -6,6 +6,8 @@
 
 #include <rpm/rpmcli.h>
 
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* rpmReadPackageFile, vercmp etc */
 #include <rpm/rpmdb.h>
 #include <rpm/rpmds.h>
 #include <rpm/rpmts.h>
diff --git a/lib/rpmlead.c b/lib/rpmlead.c
index 33c421a32..374e2a6be 100644
--- a/lib/rpmlead.c
+++ b/lib/rpmlead.c
@@ -6,8 +6,7 @@
 
 #include <netinet/in.h>
 
-#include <rpm/rpmlib.h>
-
+#include <rpm/rpmlib.h>		/* rpmGetOs/ArchInfo() */
 #include "lib/signature.h"
 #include "lib/rpmlead.h"
 #include "lib/legacy.h"
diff --git a/lib/rpmlead.h b/lib/rpmlead.h
index be91a5291..63dbe1829 100644
--- a/lib/rpmlead.h
+++ b/lib/rpmlead.h
@@ -21,7 +21,6 @@ extern "C" {
 
 typedef struct rpmlead_s * rpmlead;
 
-#include <rpm/rpmlib.h>
 
 /** \ingroup lead
  * Initialize a lead structure
diff --git a/lib/rpmlibprov.c b/lib/rpmlibprov.c
index 67424c931..5bbdcf10a 100644
--- a/lib/rpmlibprov.c
+++ b/lib/rpmlibprov.c
@@ -4,8 +4,8 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
-
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* rpmGetRpmlibProvides() & co protos */
 #include <rpm/rpmds.h>
 
 #include "debug.h"
diff --git a/lib/rpmlock.c b/lib/rpmlock.c
index 808f496f1..deeaae0b6 100644
--- a/lib/rpmlock.c
+++ b/lib/rpmlock.c
@@ -1,7 +1,6 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
 #include <rpm/rpmlog.h>
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmfileutil.h>
diff --git a/lib/rpmrc.c b/lib/rpmrc.c
index db5887965..2e5b5a937 100644
--- a/lib/rpmrc.c
+++ b/lib/rpmrc.c
@@ -13,8 +13,8 @@
 #define __power_pc() 0
 #endif
 
+#include <rpm/rpmlib.h>			/* RPM_MACTABLE*, Rc-prototypes */
 #include "rpmio/rpmio_internal.h"	/* XXX for rpmioSlurp */
-#include <rpm/rpmlib.h>
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmfileutil.h>
 #include <rpm/rpmstring.h>
diff --git a/lib/rpmte.c b/lib/rpmte.c
index e0d94bd11..552cce955 100644
--- a/lib/rpmte.c
+++ b/lib/rpmte.c
@@ -3,8 +3,9 @@
  * Routine(s) to handle an "rpmte"  transaction element.
  */
 #include "system.h"
-#include <rpm/rpmlib.h>
 
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* RPM_MACHTABLE_* */
 #include <rpm/rpmds.h>
 #include <rpm/rpmfi.h>
 
diff --git a/lib/rpmts.c b/lib/rpmts.c
index 80f96c20c..ded3acc56 100644
--- a/lib/rpmts.c
+++ b/lib/rpmts.c
@@ -4,9 +4,10 @@
  */
 #include "system.h"
 
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>			/* rpmReadPackage etc */
 #include <rpm/rpmurl.h>
 #include "rpmio/digest.h"
-#include <rpm/rpmlib.h>
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmfileutil.h>		/* rpmtsOpenDB() needs rpmGetPath */
 #include <rpm/rpmstring.h>
diff --git a/lib/rpmvercmp.c b/lib/rpmvercmp.c
index 86c9e69f3..ba5c4720d 100644
--- a/lib/rpmvercmp.c
+++ b/lib/rpmvercmp.c
@@ -4,7 +4,7 @@
 
 #include "system.h"
 
-#include <rpm/rpmlib.h>
+#include <rpm/rpmlib.h>		/* rpmvercmp proto */
 #include <rpm/rpmstring.h>
 
 #include "debug.h"
diff --git a/lib/signature.c b/lib/signature.c
index 853d997c3..ab633760a 100644
--- a/lib/signature.c
+++ b/lib/signature.c
@@ -4,8 +4,11 @@
 
 #include "system.h"
 
+#include <popt.h>
+
 #include "rpmio/digest.h"
-#include <rpm/rpmlib.h>
+#include <rpm/rpmtag.h>
+#include <rpm/rpmlib.h>		/* XXX RPMSIGTAG* & related */
 #include <rpm/rpmmacro.h>	/* XXX for rpmGetPath() */
 #include <rpm/rpmdb.h>
 #include <rpm/rpmstring.h>
diff --git a/lib/tcpu.c b/lib/tcpu.c
index 41dae7415..cc503d942 100644
--- a/lib/tcpu.c
+++ b/lib/tcpu.c
@@ -1,5 +1,8 @@
 #include "system.h"
-#include <rpm/rpmlib.h>
+
+#include <popt.h>
+
+#include <rpm/rpmio.h>
 #include <rpm/rpmmacro.h>
 #include "debug.h"
 
diff --git a/lib/tds.c b/lib/tds.c
index 149b33e1c..0389b5b6c 100644
--- a/lib/tds.c
+++ b/lib/tds.c
@@ -1,7 +1,6 @@
 #include "system.h"
 
-#include <rpm/rpmlib.h>
-
+#include <rpm/rpmtag.h>
 #include <rpm/rpmds.h>
 
 #include "debug.h"
diff --git a/lib/tgi.c b/lib/tgi.c
index 100452ebc..17c8c5e46 100644
--- a/lib/tgi.c
+++ b/lib/tgi.c
@@ -1,5 +1,6 @@
 #include "system.h"
 
+#include <rpm/rpmtag.h>
 #include <rpm/rpmgi.h>
 #include <rpm/rpmcli.h>
 
diff --git a/lib/tplatform.c b/lib/tplatform.c
index 925a5d5e6..f7383cc23 100644
--- a/lib/tplatform.c
+++ b/lib/tplatform.c
@@ -1,7 +1,6 @@
 #include "system.h"
 
 #include "rpmio/rpmio_internal.h"	/* XXX rpmioSlurp */
-#include <rpm/rpmlib.h>
 #include <rpm/rpmmacro.h>
 #include <rpm/rpmio.h>
 
diff --git a/lib/transaction.c b/lib/transaction.c
index cdc2bce80..ba3b23b67 100644
--- a/lib/transaction.c
+++ b/lib/transaction.c
@@ -3,8 +3,8 @@
  */
 
 #include "system.h"
-#include <rpm/rpmlib.h>
 
+#include <rpm/rpmlib.h>		/* rpmMachineScore, rpmReadPackageFile */
 #include <rpm/rpmmacro.h>	/* XXX for rpmExpand */
 #include <rpm/rpmlog.h>
 
diff --git a/lib/trb.c b/lib/trb.c
index e40e79b9f..9ab6d02dd 100644
--- a/lib/trb.c
+++ b/lib/trb.c
@@ -1,5 +1,6 @@
 #include "system.h"
 #include <rpm/rpmcli.h>
+#include <rpm/rpmlib.h>	/* rpmReadConfigFiles */
 #include <rpm/rpmts.h>
 #include <rpm/rpmlog.h>
 
diff --git a/lib/tthread.c b/lib/tthread.c
index b4cbb829c..b6a620bc4 100644
--- a/lib/tthread.c
+++ b/lib/tthread.c
@@ -2,7 +2,7 @@
 
 #include <pthread.h>
 #include <assert.h>
-#include <rpm/rpmlib.h>
+#include <rpm/rpmlib.h>	/* rpmReadConfigFiles, rpmReadPackageFile */
 #include <rpm/rpmts.h>
 #include <rpm/rpmsq.h>	/* XXX for _rpmsq_debug */
 #include <rpm/rpmio.h>
diff --git a/lib/verify.c b/lib/verify.c
index c0287fcbc..dff482c09 100644
--- a/lib/verify.c
+++ b/lib/verify.c
@@ -6,6 +6,7 @@
 #include "system.h"
 
 #include <rpm/rpmcli.h>
+#include <rpm/rpmtag.h>
 #include <rpm/rpmlog.h>
 
 #include "lib/psm.h"