Remove alloca() from rpmvercmp()

- use variable array instead, versions had better be short enough to fit
  on stack safely

1 files changed, 2 insertions, 4 deletions

diff --git a/lib/rpmvercmp.c b/lib/rpmvercmp.c
index d3190c1b1..0cdcc6866 100644
--- a/lib/rpmvercmp.c
+++ b/lib/rpmvercmp.c
@@ -16,7 +16,8 @@
 int rpmvercmp(const char * a, const char * b)
 {
     char oldch1, oldch2;
-    char * str1, * str2;
+    char abuf[strlen(a)+1], bbuf[strlen(b)+1];
+    char *str1 = abuf, *str2 = bbuf;
     char * one, * two;
     int rc;
     int isnum;
@@ -24,9 +25,6 @@ int rpmvercmp(const char * a, const char * b)
     /* easy comparison to see if versions are identical */
     if (!strcmp(a, b)) return 0;
 
-    str1 = alloca(strlen(a) + 1);
-    str2 = alloca(strlen(b) + 1);
-
     strcpy(str1, a);
     strcpy(str2, b);