diff options
| author | Panu Matilainen <pmatilai@redhat.com> | 2009-07-23 12:24:10 +0300 |
|---|---|---|
| committer | Panu Matilainen <pmatilai@redhat.com> | 2009-07-23 12:24:10 +0300 |
| commit | 69702c1de3e24bb44f741fbad6e961213f8db9e4 (patch) | |
| tree | e4d8969df4e0ba395b095462bd22671257c5972c /build | |
| parent | 52e4b9bcaca60499e8bb7f23eb590ce01c89c574 (diff) | |
| download | rpm-69702c1de3e24bb44f741fbad6e961213f8db9e4.tar.gz rpm-69702c1de3e24bb44f741fbad6e961213f8db9e4.tar.bz2 rpm-69702c1de3e24bb44f741fbad6e961213f8db9e4.zip | |
Kill off lclint remnants everywhere
- remove ancient and likely irrelevant LCL comments and bogus NULL checks
Diffstat (limited to 'build')
| -rw-r--r-- | build/pack.c | 3 | ||||
| -rw-r--r-- | build/parsePreamble.c | 1 | ||||
| -rw-r--r-- | build/parseSpec.c | 3 | ||||
| -rw-r--r-- | build/rpmfc.c | 1 |
4 files changed, 0 insertions, 8 deletions
diff --git a/build/pack.c b/build/pack.c index 57324ac25..b0fc4fe19 100644 --- a/build/pack.c +++ b/build/pack.c @@ -298,7 +298,6 @@ rpmRC readRPM(const char *fileName, rpmSpec *specp, { rpmts ts = rpmtsCreate(); /* XXX W2DO? pass fileName? */ - /* LCL: segfault */ rc = rpmReadPackageFile(ts, fdi, "readRPM", &spec->packages->header); @@ -782,7 +781,6 @@ rpmRC packageBinaries(rpmSpec spec) memset(csa, 0, sizeof(*csa)); csa->cpioArchiveSize = 0; - /* LCL: function typedefs */ csa->cpioFdIn = fdNew(RPMDBG_M("init (packageBinaries)")); csa->cpioList = rpmfiLink(pkg->cpioList, RPMDBG_M("packageBinaries")); @@ -839,7 +837,6 @@ rpmRC packageSources(rpmSpec spec) memset(csa, 0, sizeof(*csa)); csa->cpioArchiveSize = 0; - /* LCL: function typedefs */ csa->cpioFdIn = fdNew(RPMDBG_M("init (packageSources)")); csa->cpioList = rpmfiLink(spec->sourceCpioList, RPMDBG_M("packageSources")); diff --git a/build/parsePreamble.c b/build/parsePreamble.c index af86c7972..755dac805 100644 --- a/build/parsePreamble.c +++ b/build/parsePreamble.c @@ -251,7 +251,6 @@ exit: * @return RPMRC_OK if OK */ static int checkForRequired(Header h, const char * NVR) - /* LCL: parse error here with modifies */ { int res = RPMRC_OK; const rpmTag * p; diff --git a/build/parseSpec.c b/build/parseSpec.c index 22411b1cb..168370c14 100644 --- a/build/parseSpec.c +++ b/build/parseSpec.c @@ -441,7 +441,6 @@ int parseSpec(rpmts ts, const char *specFile, const char *rootDir, /* in the spec's line buffer. Except for parsePreamble(), */ /* which handles the initial entry into a spec file. */ - /* LCL: parsePart is modified @*/ while (parsePart != PART_NONE) { int goterror = 0; switch (parsePart) { @@ -507,7 +506,6 @@ int parseSpec(rpmts ts, const char *specFile, const char *rootDir, closeSpec(spec); - /* LCL: sizeof(spec->BASpecs[0]) -nullderef whine here */ spec->BASpecs = xcalloc(spec->BACount, sizeof(*spec->BASpecs)); index = 0; if (spec->BANames != NULL) @@ -556,7 +554,6 @@ int parseSpec(rpmts ts, const char *specFile, const char *rootDir, return 0; } } - /* LCL: parsePart is modified @*/ /* Check for description in each package and add arch and os */ { diff --git a/build/rpmfc.c b/build/rpmfc.c index bcb53836d..642be6c97 100644 --- a/build/rpmfc.c +++ b/build/rpmfc.c @@ -1056,7 +1056,6 @@ assert(s != NULL); else s = fn; -/* LCL: s is not null. */ rasprintf(&buf, "%s%s", s, #if !defined(__alpha__) isElf64 ? "()(64bit)" : ""); |