summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPanu Matilainen <pmatilai@redhat.com>2010-09-21 15:53:38 +0300
committerPanu Matilainen <pmatilai@redhat.com>2010-09-21 15:53:38 +0300
commitadd59e49eab87e98cf3ef6bedb8ce0c251199376 (patch)
tree36f2b691db7091c0184962b4236d5085d2fc61f0
parent7723fef2646e0670fc782ee5248317bb6d8f9383 (diff)
downloadrpm-add59e49eab87e98cf3ef6bedb8ce0c251199376.tar.gz
rpm-add59e49eab87e98cf3ef6bedb8ce0c251199376.tar.bz2
rpm-add59e49eab87e98cf3ef6bedb8ce0c251199376.zip
Const pedantry: taropts only ever points to string constants
-rw-r--r--build/parsePrep.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/build/parsePrep.c b/build/parsePrep.c
index 3952acc7c..7e9105628 100644
--- a/build/parsePrep.c
+++ b/build/parsePrep.c
@@ -136,7 +136,8 @@ static char *doUntar(rpmSpec spec, uint32_t c, int quietly)
{
char *fn;
char *buf = NULL;
- char *tar, *taropts;
+ char *tar;
+ const char *taropts = ((rpmIsVerbose() && !quietly) ? "-xvvf" : "-xf");
struct Source *sp;
rpmCompressedMagic compressed = COMPRESSED_NOT;
@@ -156,9 +157,6 @@ static char *doUntar(rpmSpec spec, uint32_t c, int quietly)
fn = rpmGetPath("%{_sourcedir}/", sp->source, NULL);
- /* FIX: shrug */
- taropts = ((rpmIsVerbose() && !quietly) ? "-xvvf" : "-xf");
-
#ifdef AUTOFETCH_NOT /* XXX don't expect this code to be enabled */
/* XXX
* XXX If nosource file doesn't exist, try to fetch from url.