diff options
Diffstat (limited to 'io')
-rw-r--r-- | io/channel-buffer.c | 1 | ||||
-rw-r--r-- | io/channel-socket.c | 26 | ||||
-rw-r--r-- | io/channel-websock.c | 1 | ||||
-rw-r--r-- | io/channel.c | 2 | ||||
-rw-r--r-- | io/trace-events | 63 |
5 files changed, 5 insertions, 88 deletions
diff --git a/io/channel-buffer.c b/io/channel-buffer.c index 43d795976..3e5117bf2 100644 --- a/io/channel-buffer.c +++ b/io/channel-buffer.c @@ -140,7 +140,6 @@ static int qio_channel_buffer_close(QIOChannel *ioc, QIOChannelBuffer *bioc = QIO_CHANNEL_BUFFER(ioc); g_free(bioc->data); - bioc->data = NULL; bioc->capacity = bioc->usage = bioc->offset = 0; return 0; diff --git a/io/channel-socket.c b/io/channel-socket.c index 196a4f18f..ca8bc20b1 100644 --- a/io/channel-socket.c +++ b/io/channel-socket.c @@ -23,7 +23,6 @@ #include "io/channel-socket.h" #include "io/channel-watch.h" #include "trace.h" -#include "qapi/clone-visitor.h" #define SOCKET_MAX_FDS 16 @@ -72,9 +71,6 @@ qio_channel_socket_set_fd(QIOChannelSocket *sioc, int fd, Error **errp) { - int val; - socklen_t len = sizeof(val); - if (sioc->fd != -1) { error_setg(errp, "Socket is already open"); return -1; @@ -110,10 +106,6 @@ qio_channel_socket_set_fd(QIOChannelSocket *sioc, ioc->features |= (1 << QIO_CHANNEL_FEATURE_FD_PASS); } #endif /* WIN32 */ - if (getsockopt(fd, SOL_SOCKET, SO_ACCEPTCONN, &val, &len) == 0 && val) { - QIOChannel *ioc = QIO_CHANNEL(sioc); - ioc->features |= (1 << QIO_CHANNEL_FEATURE_LISTEN); - } return 0; @@ -190,7 +182,7 @@ void qio_channel_socket_connect_async(QIOChannelSocket *ioc, OBJECT(ioc), callback, opaque, destroy); SocketAddress *addrCopy; - addrCopy = QAPI_CLONE(SocketAddress, addr); + qapi_copy_SocketAddress(&addrCopy, addr); /* socket_connect() does a non-blocking connect(), but it * still blocks in DNS lookups, so we must use a thread */ @@ -252,7 +244,7 @@ void qio_channel_socket_listen_async(QIOChannelSocket *ioc, OBJECT(ioc), callback, opaque, destroy); SocketAddress *addrCopy; - addrCopy = QAPI_CLONE(SocketAddress, addr); + qapi_copy_SocketAddress(&addrCopy, addr); /* socket_listen() blocks in DNS lookups, so we must use a thread */ trace_qio_channel_socket_listen_async(ioc, addr); @@ -332,8 +324,8 @@ void qio_channel_socket_dgram_async(QIOChannelSocket *ioc, struct QIOChannelSocketDGramWorkerData *data = g_new0( struct QIOChannelSocketDGramWorkerData, 1); - data->localAddr = QAPI_CLONE(SocketAddress, localAddr); - data->remoteAddr = QAPI_CLONE(SocketAddress, remoteAddr); + qapi_copy_SocketAddress(&data->localAddr, localAddr); + qapi_copy_SocketAddress(&data->remoteAddr, remoteAddr); trace_qio_channel_socket_dgram_async(ioc, localAddr, remoteAddr); qio_task_run_in_thread(task, @@ -401,17 +393,7 @@ static void qio_channel_socket_init(Object *obj) static void qio_channel_socket_finalize(Object *obj) { QIOChannelSocket *ioc = QIO_CHANNEL_SOCKET(obj); - if (ioc->fd != -1) { - if (QIO_CHANNEL(ioc)->features & QIO_CHANNEL_FEATURE_LISTEN) { - Error *err = NULL; - - socket_listen_cleanup(ioc->fd, &err); - if (err) { - error_report_err(err); - err = NULL; - } - } #ifdef WIN32 WSAEventSelect(ioc->fd, NULL, 0); #endif diff --git a/io/channel-websock.c b/io/channel-websock.c index 533bd4b3b..d5a4ed3f9 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -20,7 +20,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" -#include "qemu/bswap.h" #include "io/channel-websock.h" #include "crypto/hash.h" #include "trace.h" diff --git a/io/channel.c b/io/channel.c index 923c4651c..692eb179b 100644 --- a/io/channel.c +++ b/io/channel.c @@ -218,7 +218,7 @@ static gboolean qio_channel_yield_enter(QIOChannel *ioc, gpointer opaque) { QIOChannelYieldData *data = opaque; - qemu_coroutine_enter(data->co); + qemu_coroutine_enter(data->co, NULL); return FALSE; } diff --git a/io/trace-events b/io/trace-events deleted file mode 100644 index d064665f4..000000000 --- a/io/trace-events +++ /dev/null @@ -1,63 +0,0 @@ -# See docs/tracing.txt for syntax documentation. - -# io/buffer.c -buffer_resize(const char *buf, size_t olen, size_t len) "%s: old %zd, new %zd" -buffer_move_empty(const char *buf, size_t len, const char *from) "%s: %zd bytes from %s" -buffer_move(const char *buf, size_t len, const char *from) "%s: %zd bytes from %s" -buffer_free(const char *buf, size_t len) "%s: capacity %zd" - -# io/task.c -qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p" -qio_task_complete(void *task) "Task complete task=%p" -qio_task_abort(void *task) "Task abort task=%p" -qio_task_thread_start(void *task, void *worker, void *opaque) "Task thread start task=%p worker=%p opaque=%p" -qio_task_thread_run(void *task) "Task thread run task=%p" -qio_task_thread_exit(void *task) "Task thread exit task=%p" -qio_task_thread_result(void *task) "Task thread result task=%p" - -# io/channel-socket.c -qio_channel_socket_new(void *ioc) "Socket new ioc=%p" -qio_channel_socket_new_fd(void *ioc, int fd) "Socket new ioc=%p fd=%d" -qio_channel_socket_connect_sync(void *ioc, void *addr) "Socket connect sync ioc=%p addr=%p" -qio_channel_socket_connect_async(void *ioc, void *addr) "Socket connect async ioc=%p addr=%p" -qio_channel_socket_connect_fail(void *ioc) "Socket connect fail ioc=%p" -qio_channel_socket_connect_complete(void *ioc, int fd) "Socket connect complete ioc=%p fd=%d" -qio_channel_socket_listen_sync(void *ioc, void *addr) "Socket listen sync ioc=%p addr=%p" -qio_channel_socket_listen_async(void *ioc, void *addr) "Socket listen async ioc=%p addr=%p" -qio_channel_socket_listen_fail(void *ioc) "Socket listen fail ioc=%p" -qio_channel_socket_listen_complete(void *ioc, int fd) "Socket listen complete ioc=%p fd=%d" -qio_channel_socket_dgram_sync(void *ioc, void *localAddr, void *remoteAddr) "Socket dgram sync ioc=%p localAddr=%p remoteAddr=%p" -qio_channel_socket_dgram_async(void *ioc, void *localAddr, void *remoteAddr) "Socket dgram async ioc=%p localAddr=%p remoteAddr=%p" -qio_channel_socket_dgram_fail(void *ioc) "Socket dgram fail ioc=%p" -qio_channel_socket_dgram_complete(void *ioc, int fd) "Socket dgram complete ioc=%p fd=%d" -qio_channel_socket_accept(void *ioc) "Socket accept start ioc=%p" -qio_channel_socket_accept_fail(void *ioc) "Socket accept fail ioc=%p" -qio_channel_socket_accept_complete(void *ioc, void *cioc, int fd) "Socket accept complete ioc=%p cioc=%p fd=%d" - -# io/channel-file.c -qio_channel_file_new_fd(void *ioc, int fd) "File new fd ioc=%p fd=%d" -qio_channel_file_new_path(void *ioc, const char *path, int flags, int mode, int fd) "File new fd ioc=%p path=%s flags=%d mode=%d fd=%d" - -# io/channel-tls.c -qio_channel_tls_new_client(void *ioc, void *master, void *creds, const char *hostname) "TLS new client ioc=%p master=%p creds=%p hostname=%s" -qio_channel_tls_new_server(void *ioc, void *master, void *creds, const char *aclname) "TLS new client ioc=%p master=%p creds=%p acltname=%s" -qio_channel_tls_handshake_start(void *ioc) "TLS handshake start ioc=%p" -qio_channel_tls_handshake_pending(void *ioc, int status) "TLS handshake pending ioc=%p status=%d" -qio_channel_tls_handshake_fail(void *ioc) "TLS handshake fail ioc=%p" -qio_channel_tls_handshake_complete(void *ioc) "TLS handshake complete ioc=%p" -qio_channel_tls_credentials_allow(void *ioc) "TLS credentials allow ioc=%p" -qio_channel_tls_credentials_deny(void *ioc) "TLS credentials deny ioc=%p" - -# io/channel-websock.c -qio_channel_websock_new_server(void *ioc, void *master) "Websock new client ioc=%p master=%p" -qio_channel_websock_handshake_start(void *ioc) "Websock handshake start ioc=%p" -qio_channel_websock_handshake_pending(void *ioc, int status) "Websock handshake pending ioc=%p status=%d" -qio_channel_websock_handshake_reply(void *ioc) "Websock handshake reply ioc=%p" -qio_channel_websock_handshake_fail(void *ioc) "Websock handshake fail ioc=%p" -qio_channel_websock_handshake_complete(void *ioc) "Websock handshake complete ioc=%p" - -# io/channel-command.c -qio_channel_command_new_pid(void *ioc, int writefd, int readfd, int pid) "Command new pid ioc=%p writefd=%d readfd=%d pid=%d" -qio_channel_command_new_spawn(void *ioc, const char *binary, int flags) "Command new spawn ioc=%p binary=%s flags=%d" -qio_channel_command_abort(void *ioc, int pid) "Command abort ioc=%p pid=%d" -qio_channel_command_wait(void *ioc, int pid, int ret, int status) "Command abort ioc=%p pid=%d ret=%d status=%d" |