diff options
| author | Syed Tousif Ahmed <syeahmed@nvidia.com> | 2018-07-12 14:16:27 -0700 |
|---|---|---|
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2018-07-12 14:25:00 -0700 |
| commit | 34554d6adb0d1594b07051b87722402cabe9c4ec (patch) | |
| tree | bbd43569c4b0a14d61e411c17913df328d0ff12e /aten/README.md | |
| parent | 43103af7a70e141aaac906331087f892c8028426 (diff) | |
| download | pytorch-34554d6adb0d1594b07051b87722402cabe9c4ec.tar.gz pytorch-34554d6adb0d1594b07051b87722402cabe9c4ec.tar.bz2 pytorch-34554d6adb0d1594b07051b87722402cabe9c4ec.zip | |
Enable standalone build of ATen (#9377)
Summary:
This PR changes the ATen `CMakeLists.txt` slightly, to enable standalone build of ATen inside PyTorch. Currently, the tests in ATen gets linked to `libcaffe.so libcaffe2.so`. As a result, ATen can't be built standalone without building from the root pytorch directory. I know that there is a big merge happening between caffe2 and pytorch and hence, the purpose of this PR is to really start a conversation on what would be the proper way of migrating the CMakeLists to enable clean builds. We should also follow up on this PR: https://github.com/pytorch/pytorch/pull/7275. For your reference, that PR has the explanation for why `-Wl --no-as-need` is needed. Moreover, without `set(ATen_CUDA_SRCS ${all_cuda_cpp})`, the standalone build will throw unresolved references.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/9377
Reviewed By: smessmer
Differential Revision: D8825921
Pulled By: orionr
fbshipit-source-id: c521159b4885639fc7990a9819202051455d07db
Diffstat (limited to 'aten/README.md')
| -rw-r--r-- | aten/README.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/aten/README.md b/aten/README.md index a6c7a95edb..e9ada01462 100644 --- a/aten/README.md +++ b/aten/README.md @@ -48,6 +48,7 @@ sudo pip install pyyaml mkdir build cd build cmake .. -DCMAKE_INSTALL_PREFIX=/where/you/want # specify your dest directory +# cmake .. -DUSE_NVRTC=ON -DUSE_TENSORRT=OFF -DCMAKE_INSTALL_PREFIX=../install -DCAFFE2_CMAKE_BUILDING_WITH_MAIN_REPO=OFF -DUSE_CUDA=ON # for CUDA # cmake .. -DUSE_CUDA=OFF # for CPU only machines make install ``` |