diff options
author | Rich Trott <rtrott@gmail.com> | 2016-04-01 22:20:55 -0700 |
---|---|---|
committer | Myles Borins <mborins@us.ibm.com> | 2016-04-11 12:52:45 -0400 |
commit | 73e3b7b9a8e01746edc1e7db8699fd435ea292d6 (patch) | |
tree | 07d5c3c4d76b59153b2f2d1d758b72b63db9cea0 | |
parent | bb603b89a2212da689491cf8cf60e64e341aeb40 (diff) | |
download | nodejs-73e3b7b9a8e01746edc1e7db8699fd435ea292d6.tar.gz nodejs-73e3b7b9a8e01746edc1e7db8699fd435ea292d6.tar.bz2 nodejs-73e3b7b9a8e01746edc1e7db8699fd435ea292d6.zip |
test: make use of globals explicit
Use `global` to be explicit that a global variable is intended.
PR-URL: https://github.com/nodejs/node/pull/6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | test/parallel/test-vm-static-this.js | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/test/parallel/test-vm-static-this.js b/test/parallel/test-vm-static-this.js index a5f5ad941..143e4e122 100644 --- a/test/parallel/test-vm-static-this.js +++ b/test/parallel/test-vm-static-this.js @@ -14,25 +14,25 @@ assert.throws(function() { vm.runInThisContext('throw new Error(\'test\');'); }, /test/); -hello = 5; +global.hello = 5; vm.runInThisContext('hello = 2'); -assert.equal(2, hello); +assert.equal(2, global.hello); console.error('pass values'); -code = 'foo = 1;' + +var code = 'foo = 1;' + 'bar = 2;' + 'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');'; -foo = 2; -obj = { foo: 0, baz: 3 }; +global.foo = 2; +global.obj = { foo: 0, baz: 3 }; /* eslint-disable no-unused-vars */ var baz = vm.runInThisContext(code); /* eslint-enable no-unused-vars */ -assert.equal(0, obj.foo); -assert.equal(2, bar); -assert.equal(1, foo); +assert.equal(0, global.obj.foo); +assert.equal(2, global.bar); +assert.equal(1, global.foo); console.error('call a function'); -f = function() { foo = 100; }; +global.f = function() { global.foo = 100; }; vm.runInThisContext('f()'); -assert.equal(100, foo); +assert.equal(100, global.foo); |