diff options
author | Dan Winship <danw@gnome.org> | 2009-06-06 18:52:30 -0400 |
---|---|---|
committer | Dan Winship <danw@gnome.org> | 2009-06-06 22:58:49 -0400 |
commit | dee7dc77b3ec662f60044f25abe6b5193b87f086 (patch) | |
tree | 016678b3dbdac9d23f5fffceb9804f2a0340e176 /tests | |
parent | 777af4c8ec7b73d3c2376091401c00cb945cd6fc (diff) | |
download | libsoup-dee7dc77b3ec662f60044f25abe6b5193b87f086.tar.gz libsoup-dee7dc77b3ec662f60044f25abe6b5193b87f086.tar.bz2 libsoup-dee7dc77b3ec662f60044f25abe6b5193b87f086.zip |
Fix hostname resolution behavior
Previously we went to some effort to resolve the message URI hostname
to an IP address before figuring out proxies/connections, but this
turns out to be wrong for multiple reasons:
1. Some hosts that send all requests via proxy don't even have a
working DNS config.
(http://bugzilla.gnome.org/show_bug.cgi?id=577532)
2. Apparently no one expects hostnames in requests to be matched
against IP addresses in proxy ignore lists anyway.
3. The big web browsers all implement connection limits on a
per-hostname basis, not a per-IP basis, and some web pages take
advantage of this by using multiple aliases for the same host
to get around the connection limit.
Also update tests/proxy-test to verify that the hostname is not
resolved when passing a request to a proxy.
Diffstat (limited to 'tests')
-rw-r--r-- | tests/proxy-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/proxy-test.c b/tests/proxy-test.c index ebdd2cc1..8f57c1f0 100644 --- a/tests/proxy-test.c +++ b/tests/proxy-test.c @@ -21,7 +21,7 @@ static SoupProxyTest tests[] = { { "GET -> 404", "/not-found", SOUP_STATUS_NOT_FOUND }, { "GET -> 401 -> 200", "/Basic/realm1/", SOUP_STATUS_OK }, { "GET -> 401 -> 401", "/Basic/realm2/", SOUP_STATUS_UNAUTHORIZED }, - { "GET -> 403", "http://www.example.com/", SOUP_STATUS_FORBIDDEN }, + { "GET -> 403", "http://no-such-hostname.xx/", SOUP_STATUS_FORBIDDEN }, }; static int ntests = sizeof (tests) / sizeof (tests[0]); |