diff options
| author | Dan Winship <danw@src.gnome.org> | 2008-04-05 13:56:22 +0000 |
|---|---|---|
| committer | Dan Winship <danw@src.gnome.org> | 2008-04-05 13:56:22 +0000 |
| commit | 060b86b7d13cff079fb51548971b72bf9065a01e (patch) | |
| tree | fefb5fe47090be4cc2a6f99f2a56ce42d52878ff /tests/test-utils.c | |
| parent | 96d3d91fd7baee98a037fd105360d847ae769685 (diff) | |
| download | libsoup-060b86b7d13cff079fb51548971b72bf9065a01e.tar.gz libsoup-060b86b7d13cff079fb51548971b72bf9065a01e.tar.bz2 libsoup-060b86b7d13cff079fb51548971b72bf9065a01e.zip | |
Misc fixes noticed by "sparse" or by running gcc with additional
-W flags
* libsoup/soup-auth-manager-ntlm.c (ntlm_authorize_post): fix a
potentially uninitialized variable. (Grumble. gcc needs
-Wdo-optimization-so-you-can-generate-code-flow-related-warnings-
but-then-emit-unoptimized-code-for-ease-of-debugging)
* libsoup/soup-gnutls.c (soup_gnutls_channel_funcs): make this
static
* libsoup/soup-uri.c (uri_decoded_copy, uri_normalized_copy): add
"static". (This doesn't change the generated code; the prototype
was already declared static and so gcc was treating the function
as static even though the main declaration *wasn't* declared
static. I'm not sure if this is a bug in gcc or an oddity of the
spec, but it's confusing, so...)
* libsoup/soup-xmlrpc.c (soup_xmlrpc_build_method_response):
s/FALSE/NULL/
* libsoup/soup-xmlrpc.h: add G_GNUC_PRINTF to
soup_xmlrpc_build_format
* tests/*.c: misc minor fixes, mostly involving missing "const"s
and "static"s to get better warnings, and then remove some unused
variables.
* tests/continue-test.c (do_message): fix a crash when the test
fails
* tests/test-utils.h (debug_printf): add G_GNUC_PRINTF to
prototype
svn path=/trunk/; revision=1123
Diffstat (limited to 'tests/test-utils.c')
| -rw-r--r-- | tests/test-utils.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/test-utils.c b/tests/test-utils.c index 3c1005b7..faab14ab 100644 --- a/tests/test-utils.c +++ b/tests/test-utils.c @@ -17,12 +17,13 @@ static gboolean apache_running; #endif static SoupServer *test_server; -GThread *server_thread; +static GThread *server_thread; static void test_server_shutdown (void); static SoupLogger *logger; -int debug_level, http_debug_level, errors; +int debug_level, errors; +static int http_debug_level; static gboolean increment_debug_level (const char *option_name, const char *value, |