From 060b86b7d13cff079fb51548971b72bf9065a01e Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Sat, 5 Apr 2008 13:56:22 +0000 Subject: Misc fixes noticed by "sparse" or by running gcc with additional -W flags * libsoup/soup-auth-manager-ntlm.c (ntlm_authorize_post): fix a potentially uninitialized variable. (Grumble. gcc needs -Wdo-optimization-so-you-can-generate-code-flow-related-warnings- but-then-emit-unoptimized-code-for-ease-of-debugging) * libsoup/soup-gnutls.c (soup_gnutls_channel_funcs): make this static * libsoup/soup-uri.c (uri_decoded_copy, uri_normalized_copy): add "static". (This doesn't change the generated code; the prototype was already declared static and so gcc was treating the function as static even though the main declaration *wasn't* declared static. I'm not sure if this is a bug in gcc or an oddity of the spec, but it's confusing, so...) * libsoup/soup-xmlrpc.c (soup_xmlrpc_build_method_response): s/FALSE/NULL/ * libsoup/soup-xmlrpc.h: add G_GNUC_PRINTF to soup_xmlrpc_build_format * tests/*.c: misc minor fixes, mostly involving missing "const"s and "static"s to get better warnings, and then remove some unused variables. * tests/continue-test.c (do_message): fix a crash when the test fails * tests/test-utils.h (debug_printf): add G_GNUC_PRINTF to prototype svn path=/trunk/; revision=1123 --- tests/test-utils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'tests/test-utils.c') diff --git a/tests/test-utils.c b/tests/test-utils.c index 3c1005b7..faab14ab 100644 --- a/tests/test-utils.c +++ b/tests/test-utils.c @@ -17,12 +17,13 @@ static gboolean apache_running; #endif static SoupServer *test_server; -GThread *server_thread; +static GThread *server_thread; static void test_server_shutdown (void); static SoupLogger *logger; -int debug_level, http_debug_level, errors; +int debug_level, errors; +static int http_debug_level; static gboolean increment_debug_level (const char *option_name, const char *value, -- cgit v1.2.3