Merge pull request #11883 from JosephTremoulet/PromotedStructRefs

Update full-struct references to promoted IBR args

2 files changed, 88 insertions, 0 deletions

diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_11814/GitHub_11814.cs b/tests/src/JIT/Regression/JitBlue/GitHub_11814/GitHub_11814.cs
new file mode 100644
index 0000000000..16ca8c2f27
--- /dev/null
+++ b/tests/src/JIT/Regression/JitBlue/GitHub_11814/GitHub_11814.cs
@@ -0,0 +1,45 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+// Repro case for a bug involving failure to rewrite all references
+// to a promoted implicit byref struct parameter.
+
+using System;
+using System.Runtime.CompilerServices;
+
+class MutateStructArg
+{
+    public struct P
+    {
+        public string S;
+        public int X;
+    }
+
+    public static int Main()
+    {
+        P l1 = new P();
+        l1.S = "Hello World";
+        l1.X = 42;
+        P l2 = foo(l1);
+        Console.WriteLine(l2.S); // Print modified value "Goodbye World"
+        if ((l2.S == "Goodbye World") && (l2.X == 100))
+        {
+            return 100;   // success
+        }
+        else
+        {
+            Console.WriteLine("**** Test FAILED ***");
+            return 1;  // failure
+        }
+    }
+
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    public static P foo(P a)
+    {
+        Console.WriteLine(a.S);   // Print the incoming value "Hello World"
+        a.S = "Goodbye World";    // Mutate the incoming value
+        a.X = 100;
+        return a;                 // Copy the modified value to the return value (bug was that this was returning original unmodified arg)
+    }
+}
diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_11814/GitHub_11814.csproj b/tests/src/JIT/Regression/JitBlue/GitHub_11814/GitHub_11814.csproj
new file mode 100644
index 0000000000..2db21106fd
--- /dev/null
+++ b/tests/src/JIT/Regression/JitBlue/GitHub_11814/GitHub_11814.csproj
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <AssemblyName>$(MSBuildProjectName)</AssemblyName>
+    <SchemaVersion>2.0</SchemaVersion>
+    <ProjectGuid>{7B521917-193E-48BB-86C6-FE013F3DFF35}</ProjectGuid>
+    <OutputType>Exe</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <FileAlignment>512</FileAlignment>
+    <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
+    <ReferencePath>$(ProgramFiles)\Common Files\microsoft shared\VSTT\11.0\UITestExtensionPackages</ReferencePath>
+    <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
+
+    <NuGetPackageImportStamp>7a9bfb7d</NuGetPackageImportStamp>
+  </PropertyGroup>
+  <!-- Default configurations to help VS understand the configurations -->
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+  </PropertyGroup>
+  <ItemGroup>
+    <CodeAnalysisDependentAssemblyPaths Condition=" '$(VS100COMNTOOLS)' != '' " Include="$(VS100COMNTOOLS)..\IDE\PrivateAssemblies">
+      <Visible>False</Visible>
+    </CodeAnalysisDependentAssemblyPaths>
+  </ItemGroup>
+  <PropertyGroup>
+    <DebugType></DebugType>
+    <Optimize>True</Optimize>
+    <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
+  </PropertyGroup>
+  <ItemGroup>
+    <Compile Include="GitHub_11814.cs" />
+  </ItemGroup>
+  <ItemGroup>
+    <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
+  </ItemGroup>
+  <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
+  <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' ">
+  </PropertyGroup>
+</Project>