diff options
| author | Michal Strehovský <MichalStrehovsky@users.noreply.github.com> | 2019-03-11 21:58:20 +0100 |
|---|---|---|
| committer | Jan Kotas <jkotas@microsoft.com> | 2019-03-11 13:58:20 -0700 |
| commit | 27b39d83535231d31f562002b78ac1e1b3b54be3 (patch) | |
| tree | e49298d2beadf89e85820f22381b1d25b02ec0a9 /tests | |
| parent | 873cc91a6e88364fd758dec2eb61ed20017cfdee (diff) | |
| download | coreclr-27b39d83535231d31f562002b78ac1e1b3b54be3.tar.gz coreclr-27b39d83535231d31f562002b78ac1e1b3b54be3.tar.bz2 coreclr-27b39d83535231d31f562002b78ac1e1b3b54be3.zip | |
Fix bad test (#23173)
The test was testing that a non-virtual call to an abstract method that is methodimpl on the same type will land in the methodimpl. This behavior is not specced and cannot be hit with any mainstream .NET languages. We are making non-virtual calls to abstract methods throw a BadImageFormatException instead.
Fixes #23096.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/issues.targets | 3 | ||||
| -rw-r--r-- | tests/src/Loader/classloader/regressions/429802/CMain.il | 20 |
2 files changed, 10 insertions, 13 deletions
diff --git a/tests/issues.targets b/tests/issues.targets index e4bde3b22d..eb34df3ca6 100644 --- a/tests/issues.targets +++ b/tests/issues.targets @@ -71,9 +71,6 @@ <ExcludeList Include="$(XunitTestBinBase)/baseservices/threading/waithandle/waitany/waitanyex2a/*"> <Issue>19406</Issue> </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/regressions/429802/CMain/*"> - <Issue>23096</Issue> - </ExcludeList> </ItemGroup> <!-- All Unix targets --> diff --git a/tests/src/Loader/classloader/regressions/429802/CMain.il b/tests/src/Loader/classloader/regressions/429802/CMain.il index da86838fae..52b9f8b2a3 100644 --- a/tests/src/Loader/classloader/regressions/429802/CMain.il +++ b/tests/src/Loader/classloader/regressions/429802/CMain.il @@ -82,16 +82,16 @@ IL_002d: call void [mscorlib_1]System.Console::WriteLine(string) IL_0032: ldc.i4.0 IL_0033: stloc.0 - IL_0034: ldc.i4.1 - IL_0035: ldloc.2 - IL_0036: call instance int32 [MyBar]MyBar::DoBar() - IL_003b: beq.s IL_0049 - - IL_003d: ldstr "FAIL: expected MyBar.DoSelfBar to execute, but ano" - + "ther method was executed instead." - IL_0042: call void [mscorlib_1]System.Console::WriteLine(string) - IL_0047: ldc.i4.0 - IL_0048: stloc.0 + IL_0034: + + + + + + + + + IL_0049: ldloc.0 IL_004a: brtrue.s IL_005b |