Enable Tiered Compilation by default (#19525)

Enable Tiered Compilation by default

1) Changes the default state of the tiered compilation feature check to be ON BY DEFAULT
2) Removed comments about the source about this being a work in progress. Although it will surely continue to evolve and improve, remaining issues would be better tracked in our issue tracking system with the same default presumption as other runtime features - assume it works unless noted otherwise.
3) Adjusts a number of tests and automated scripts that made assumptions that the default setting of this feature is off.
4) Stop accepting the deprecated env var COMPLUS_EXPERIMENTAL_TieredCompilation. I'm not aware it has any remaining usage but if so we're going to find out.
5) Adjust config names for JitBench

1 files changed, 5 insertions, 8 deletions

diff --git a/tests/src/performance/Scenario/JitBench/Runner/BenchmarkConfiguration.cs b/tests/src/performance/Scenario/JitBench/Runner/BenchmarkConfiguration.cs
index 7043489fa5..bdc8ac7dad 100644
--- a/tests/src/performance/Scenario/JitBench/Runner/BenchmarkConfiguration.cs
+++ b/tests/src/performance/Scenario/JitBench/Runner/BenchmarkConfiguration.cs
@@ -11,22 +11,19 @@ namespace JitBench
             Name = "Default";
             EnvironmentVariables = new Dictionary<string, string>();
         }
+
         public bool IsDefault {  get { return Name == "Default"; } }
         public string Name { get; set; }
         public Dictionary<string, string> EnvironmentVariables { get; private set; }
 
-        public BenchmarkConfiguration WithTiering()
+        public BenchmarkConfiguration WithoutTiering()
         {
-            return WithModifier("Tiering", "COMPLUS_TieredCompilation", "1");
+            return WithModifier("NoTiering", "COMPlus_TieredCompilation", "0");
         }
 
         public BenchmarkConfiguration WithMinOpts()
         {
-            BenchmarkConfiguration configuration =
-                WithModifier("Minopts", "COMPLUS_JitMinOpts", "1").
-                WithModifier("Tiering", "COMPLUS_TieredCompilation", "0");
-            configuration.Name = "Minopts";
-            return configuration;
+            return WithModifier("Minopts", "COMPlus_JitMinOpts", "1");
         }
 
         public BenchmarkConfiguration WithNoR2R()
@@ -36,7 +33,7 @@ namespace JitBench
 
         public BenchmarkConfiguration WithNoNgen()
         {
-            return WithModifier("NoNgen", "COMPLUS_ZapDisable", "1");
+            return WithModifier("NoNgen", "COMPlus_ZapDisable", "1");
         }
 
         private BenchmarkConfiguration WithModifier(string modifier, string variableName, string variableValue)