diff options
| author | Pat Gavlin <pgavlin@gmail.com> | 2016-08-24 15:50:04 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-08-24 15:50:04 -0700 |
| commit | 2c38643f91d98a278d8084c2d776d927a4405e16 (patch) | |
| tree | 1c6986afc85aae4654a848cdae66d349012e1f07 /tests/issues.targets | |
| parent | a352d949e5342e13b1ac1f545711d7f5d12bd8ce (diff) | |
| download | coreclr-2c38643f91d98a278d8084c2d776d927a4405e16.tar.gz coreclr-2c38643f91d98a278d8084c2d776d927a4405e16.tar.bz2 coreclr-2c38643f91d98a278d8084c2d776d927a4405e16.zip | |
Fix #3554. (#6880)
On x86, `emitter::emitInsBinary` was calling `genProduceReg` on the
`dst` tree if the source was a contained class field load and the
destination was a register. As per the comment on the offending
function, it is the caller's responsibility to call `genProduceReg`
for the destination register, if any. This was causing errors in
GC ref reporting on x86. This issue did not appear on x64 because
AFAICT we very nearly always morph class field loads into loads of
a `CNS_INT` handle (see morph.cpp:6344 in `fgMorphField` for
details).
Diffstat (limited to 'tests/issues.targets')
| -rw-r--r-- | tests/issues.targets | 27 |
1 files changed, 0 insertions, 27 deletions
diff --git a/tests/issues.targets b/tests/issues.targets index d39e38932e..e40477c221 100644 --- a/tests/issues.targets +++ b/tests/issues.targets @@ -266,36 +266,9 @@ <!-- The following x86 failures only occur with RyuJIT/x86 --> <ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(BuildArch)' == 'x86'"> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\_Simpletest1\_Simpletest1.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\_XAssemblytest1-xassem\_XAssemblytest1-xassem.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\_XModuletest1-xmod\_XModuletest1-xmod.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\test1-xassem\test1-xassem.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\test4-xassem\test4-xassem.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\_Simpletest4\_Simpletest4.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\_XAssemblytest4-xassem\_XAssemblytest4-xassem.cmd"> - <Issue>3554</Issue> - </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\stringintern\_XModuletest4-xmod\_XModuletest4-xmod.cmd"> - <Issue>3554</Issue> - </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)\JIT\Performance\CodeQuality\Serialization\Serialize\Serialize.cmd"> <Issue>3597</Issue> </ExcludeList> - <ExcludeList Include="$(XunitTestBinBase)\JIT\Performance\CodeQuality\V8\DeltaBlue\DeltaBlue\DeltaBlue.cmd"> - <Issue>4817</Issue> - </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\MDArray\basics\stringarr_cs_do\stringarr_cs_do.cmd"> <Issue>4844</Issue> </ExcludeList> |