summaryrefslogtreecommitdiff
path: root/src/vm
diff options
context:
space:
mode:
authordanmosemsft <danmose@microsoft.com>2017-02-12 11:12:36 -0800
committerdanmosemsft <danmose@microsoft.com>2017-02-12 16:58:48 -0800
commit5b9f6a1c0f09d74ea7fe870c7b6c14fe9b5002cc (patch)
tree6efc019bd85071dfad4abb0f559ed8c5124e1cd0 /src/vm
parentc65413fd6470e853ceb02649906cdbc164700a97 (diff)
downloadcoreclr-5b9f6a1c0f09d74ea7fe870c7b6c14fe9b5002cc.tar.gz
coreclr-5b9f6a1c0f09d74ea7fe870c7b6c14fe9b5002cc.tar.bz2
coreclr-5b9f6a1c0f09d74ea7fe870c7b6c14fe9b5002cc.zip
Remove always defined FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
Diffstat (limited to 'src/vm')
-rw-r--r--src/vm/ecalllist.h4
-rw-r--r--src/vm/mdaassistants.cpp2
-rw-r--r--src/vm/metasig.h2
-rw-r--r--src/vm/mscorlib.h2
-rw-r--r--src/vm/object.h8
-rw-r--r--src/vm/synchronizationcontextnative.cpp2
-rw-r--r--src/vm/synchronizationcontextnative.h2
-rw-r--r--src/vm/threads.cpp4
-rw-r--r--src/vm/threads.h6
9 files changed, 0 insertions, 32 deletions
diff --git a/src/vm/ecalllist.h b/src/vm/ecalllist.h
index 0cd188590d..cdf9446ed6 100644
--- a/src/vm/ecalllist.h
+++ b/src/vm/ecalllist.h
@@ -1285,9 +1285,7 @@ FCFuncStart(gCompilerFuncs)
FCFuncEnd()
FCFuncStart(gContextSynchronizationFuncs)
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
FCFuncElement("WaitHelperNative", SynchronizationContextNative::WaitHelper)
-#endif // #ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_APPX
QCFuncElement("GetWinRTDispatcherForCurrentThread", SynchronizationContextNative::GetWinRTDispatcherForCurrentThread)
#endif
@@ -1695,9 +1693,7 @@ FCClassElement("Stream", "System.IO", gStreamFuncs)
FCClassElement("String", "System", gStringFuncs)
FCClassElement("StringBuilder", "System.Text", gStringBufferFuncs)
FCClassElement("StubHelpers", "System.StubHelpers", gStubHelperFuncs)
-#if defined(FEATURE_SYNCHRONIZATIONCONTEXT_WAIT) || defined(FEATURE_APPX)
FCClassElement("SynchronizationContext", "System.Threading", gContextSynchronizationFuncs)
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT || FEATURE_APPX
#if !defined(FEATURE_COREFX_GLOBALIZATION)
FCClassElement("TextInfo", "System.Globalization", gTextInfoFuncs)
#endif // !defined(FEATURE_COREFX_GLOBALIZATION)
diff --git a/src/vm/mdaassistants.cpp b/src/vm/mdaassistants.cpp
index e52e8ff8ec..eb9a448a3a 100644
--- a/src/vm/mdaassistants.cpp
+++ b/src/vm/mdaassistants.cpp
@@ -139,7 +139,6 @@ void TriggerGCForMDAInternal()
{
GCHeapUtilities::GetGCHeap()->GarbageCollect();
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
//
// It is very dangerous to wait for finalizer thread here if we are inside a wait
// operation, as the wait operation might call into interop which calls this MDA
@@ -150,7 +149,6 @@ void TriggerGCForMDAInternal()
// So, if we are inside a SyncContext.Wait, don't call out to FinalizerThreadWait
//
if (!GetThread()->HasThreadStateNC(Thread::TSNC_InsideSyncContextWait))
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
// It is possible that user code run as part of finalization will wait for this thread.
// To avoid deadlocks, we limit the wait time to 10 seconds (an arbitrary number).
FinalizerThread::FinalizerThreadWait(10 * 1000);
diff --git a/src/vm/metasig.h b/src/vm/metasig.h
index b452cf4c26..94a779555c 100644
--- a/src/vm/metasig.h
+++ b/src/vm/metasig.h
@@ -569,10 +569,8 @@ DEFINE_METASIG_T(SM(Obj_ArrStr_ArrObj_OutStreamingContext_RetSerializationInfo,
#endif // FEATURE_SERIALIZATION
DEFINE_METASIG(SM(Obj_OutStr_OutStr_OutArrStr_OutArrObj_RetObj, j r(s) r(s) r(a(s)) r(a(j)), j))
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
// Execution Context
DEFINE_METASIG_T(SM(SyncCtx_ArrIntPtr_Bool_Int_RetInt, C(SYNCHRONIZATION_CONTEXT) a(I) F i, i))
-#endif // #ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_COMINTEROP
// The signature of the method System.Runtime.InteropServices.ICustomQueryInterface.GetInterface
diff --git a/src/vm/mscorlib.h b/src/vm/mscorlib.h
index 5b802ff1f3..6a83510166 100644
--- a/src/vm/mscorlib.h
+++ b/src/vm/mscorlib.h
@@ -1318,12 +1318,10 @@ DEFINE_CLASS(STRONG_NAME_KEY_PAIR, Reflection, StrongNameKeyPair)
DEFINE_METHOD(STRONG_NAME_KEY_PAIR, GET_KEY_PAIR, GetKeyPair, IM_RefObject_RetBool)
#endif
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
DEFINE_CLASS_U(Threading, SynchronizationContext, SynchronizationContextObject)
DEFINE_FIELD_U(_props, SynchronizationContextObject, _props)
DEFINE_CLASS(SYNCHRONIZATION_CONTEXT, Threading, SynchronizationContext)
DEFINE_METHOD(SYNCHRONIZATION_CONTEXT, INVOKE_WAIT_METHOD_HELPER, InvokeWaitMethodHelper, SM_SyncCtx_ArrIntPtr_Bool_Int_RetInt)
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_COMINTEROP_TLB_SUPPORT
DEFINE_CLASS(TCE_EVENT_ITF_INFO, InteropTCE, EventItfInfo)
diff --git a/src/vm/object.h b/src/vm/object.h
index 8a987db0b1..ababdbadaa 100644
--- a/src/vm/object.h
+++ b/src/vm/object.h
@@ -1599,7 +1599,6 @@ typedef SecurityContextObject* SECURITYCONTEXTREF;
#endif
#endif // #if defined(FEATURE_IMPERSONATION) || defined(FEATURE_COMPRESSEDSTACK)
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#define SYNCCTXPROPS_REQUIRESWAITNOTIFICATION 0x1 // Keep in sync with SynchronizationContext.cs SynchronizationContextFlags
class ThreadBaseObject;
class SynchronizationContextObject: public Object
@@ -1620,7 +1619,6 @@ public:
return FALSE;
}
};
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_REMOTING
class CallContextRemotingDataObject : public Object
@@ -1737,17 +1735,13 @@ typedef LogicalCallContextObject* LOGICALCALLCONTEXTREF;
typedef DPTR(class CultureInfoBaseObject) PTR_CultureInfoBaseObject;
#ifdef USE_CHECKED_OBJECTREFS
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
typedef REF<SynchronizationContextObject> SYNCHRONIZATIONCONTEXTREF;
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
typedef REF<ExecutionContextObject> EXECUTIONCONTEXTREF;
typedef REF<CultureInfoBaseObject> CULTUREINFOBASEREF;
typedef REF<ArrayBase> ARRAYBASEREF;
#else
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
typedef SynchronizationContextObject* SYNCHRONIZATIONCONTEXTREF;
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
typedef CultureInfoBaseObject* CULTUREINFOBASEREF;
typedef PTR_ArrayBase ARRAYBASEREF;
#endif
@@ -2109,13 +2103,11 @@ public:
}
#endif // FEATURE_LEAK_CULTURE_INFO
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
OBJECTREF GetSynchronizationContext()
{
LIMITED_METHOD_CONTRACT;
return m_SynchronizationContext;
}
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_COMPRESSEDSTACK
COMPRESSEDSTACKREF GetCompressedStack()
diff --git a/src/vm/synchronizationcontextnative.cpp b/src/vm/synchronizationcontextnative.cpp
index 4c37b75c73..ac67f39349 100644
--- a/src/vm/synchronizationcontextnative.cpp
+++ b/src/vm/synchronizationcontextnative.cpp
@@ -20,7 +20,6 @@
#endif
#include "synchronizationcontextnative.h"
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
FCIMPL3(DWORD, SynchronizationContextNative::WaitHelper, PTRArray *handleArrayUNSAFE, CLR_BOOL waitAll, DWORD millis)
{
FCALL_CONTRACT;
@@ -46,7 +45,6 @@ FCIMPL3(DWORD, SynchronizationContextNative::WaitHelper, PTRArray *handleArrayUN
return ret;
}
FCIMPLEND
-#endif // #ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_APPX
diff --git a/src/vm/synchronizationcontextnative.h b/src/vm/synchronizationcontextnative.h
index ebbcc2faf9..917d3a0afb 100644
--- a/src/vm/synchronizationcontextnative.h
+++ b/src/vm/synchronizationcontextnative.h
@@ -19,9 +19,7 @@ class SynchronizationContextNative
{
public:
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
static FCDECL3(DWORD, WaitHelper, PTRArray *handleArrayUNSAFE, CLR_BOOL waitAll, DWORD millis);
-#endif
#ifdef FEATURE_APPX
static void* QCALLTYPE GetWinRTDispatcherForCurrentThread();
diff --git a/src/vm/threads.cpp b/src/vm/threads.cpp
index 3c90c87c1e..26c8dceb86 100644
--- a/src/vm/threads.cpp
+++ b/src/vm/threads.cpp
@@ -4241,7 +4241,6 @@ DWORD Thread::DoAppropriateWaitWorker(int countHandles, HANDLE *handles, BOOL wa
DWORD ret = 0;
BOOL alertable = (mode & WaitMode_Alertable) != 0;
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
// Waits from SynchronizationContext.WaitHelper are always just WaitMode_IgnoreSyncCtx.
// So if we defer to a sync ctx, we will lose any extra bits. We must therefore not
// defer to a sync ctx if doing any non-default wait.
@@ -4283,7 +4282,6 @@ DWORD Thread::DoAppropriateWaitWorker(int countHandles, HANDLE *handles, BOOL wa
if (fSyncCtxPresent)
return ret;
}
-#endif // #ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
// Before going to pre-emptive mode the thread needs to be flagged as waiting for
// the debugger. This used to be accomplished by the TS_Interruptible flag but that
@@ -4707,7 +4705,6 @@ WaitCompleted:
}
#endif // !FEATURE_PAL
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
DWORD Thread::DoSyncContextWait(OBJECTREF *pSyncCtxObj, int countHandles, HANDLE *handles, BOOL waitAll, DWORD millis)
{
CONTRACTL
@@ -4737,7 +4734,6 @@ DWORD Thread::DoSyncContextWait(OBJECTREF *pSyncCtxObj, int countHandles, HANDLE
return invokeWaitMethodHelper.Call_RetI4(args);
}
-#endif // #ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
// Called out of SyncBlock::Wait() to block this thread until the Notify occurs.
BOOL Thread::Block(INT32 timeOut, PendingSync *syncState)
diff --git a/src/vm/threads.h b/src/vm/threads.h
index a7f400e7dc..7d41fe8e5a 100644
--- a/src/vm/threads.h
+++ b/src/vm/threads.h
@@ -1269,9 +1269,7 @@ public:
// effort.
//
// Once we are completely independent of the OS UEF, we could remove this.
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
TSNC_InsideSyncContextWait = 0x02000000, // Whether we are inside DoSyncContextWait
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
TSNC_DebuggerSleepWaitJoin = 0x04000000, // Indicates to the debugger that this thread is in a sleep wait or join state
// This almost mirrors the TS_Interruptible state however that flag can change
// during GC-preemptive mode whereas this one cannot.
@@ -2692,7 +2690,6 @@ public:
return (ObjectFromHandle(m_ExposedObject) != NULL) ;
}
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
void GetSynchronizationContext(OBJECTREF *pSyncContextObj)
{
CONTRACTL
@@ -2710,7 +2707,6 @@ public:
if (ExposedThreadObj != NULL)
*pSyncContextObj = ExposedThreadObj->GetSynchronizationContext();
}
-#endif // FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
#ifdef FEATURE_COMPRESSEDSTACK
OBJECTREF GetCompressedStack()
@@ -3406,9 +3402,7 @@ private:
DWORD DoSignalAndWaitWorker(HANDLE* pHandles, DWORD millis,BOOL alertable);
#endif // !FEATURE_PAL
DWORD DoAppropriateAptStateWait(int numWaiters, HANDLE* pHandles, BOOL bWaitAll, DWORD timeout, WaitMode mode);
-#ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
DWORD DoSyncContextWait(OBJECTREF *pSyncCtxObj, int countHandles, HANDLE *handles, BOOL waitAll, DWORD millis);
-#endif // #ifdef FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
public:
//************************************************************************