diff options
author | Pat Gavlin <pgavlin@gmail.com> | 2016-08-31 10:56:11 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-08-31 10:56:11 -0700 |
commit | fd5a96d96fdcc4a1a439b211d15ceca3a110a1eb (patch) | |
tree | 3de3303536c2abdf22e4daf3af1ccc86850dccb3 /src/jit/gtlist.h | |
parent | cc9b02413335a07c81f2155a89fb7487def29efe (diff) | |
download | coreclr-fd5a96d96fdcc4a1a439b211d15ceca3a110a1eb.tar.gz coreclr-fd5a96d96fdcc4a1a439b211d15ceca3a110a1eb.tar.bz2 coreclr-fd5a96d96fdcc4a1a439b211d15ceca3a110a1eb.zip |
Fix #6893. (#6932)
Aggregate arguments to calls (i.e. arguments that are made up
of multiple, independent values such as those to be passed in
multiple registers) are represented by GT_LIST nodes that are
not distiguishable from normal GT_LIST nodes without the extra
context of the call. GT_LIST nodes, however, are disallowed in
LIR ranges. The intersection of these two design choices causes
problems for code that operates on LIR but wants to observe
aggregate arguments as a whole (rather than piecewise). In the
case of #6893, this caused lowering to attempt to insert a
PUTARG_STK node after the GT_LIST node that represented the
aggregate argument that was being forced to the stack, which
caused an assertion in the LIR utilities to fail (the GT_LIST
node was passed as the insertion point to `LIR::Range::InsertAfter`,
which requires that the insertion point be a part of the given
range).
Conceptually, the fix is simple: the nodes that represent
aggregate arguments must be allowed to be part of LIR ranges.
The implementation, however, is complicated somewhat by the
need to distinguish the nodes used for aggregate arguments from
normal GT_LIST nodes. These changes implement a short-term
fix that distiguished these nodes by adding a node-specific flag,
`GTF_LIST_AGGREGATE`, to indicate that a GT_LIST node is in fact
an aggregate argument. In the long term, a more palatable
implementation would be the introduction of a new node and operator
type to represent aggregate arguments, but this is likely to
require broader changes to the compiler.
Diffstat (limited to 'src/jit/gtlist.h')
-rw-r--r-- | src/jit/gtlist.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/jit/gtlist.h b/src/jit/gtlist.h index 59e59b972e..6b5f9402dd 100644 --- a/src/jit/gtlist.h +++ b/src/jit/gtlist.h @@ -176,7 +176,7 @@ GTNODE(SIMD , "simd" ,0,GTK_BINOP|GTK_EXOP) // SIMD functions/oper GTNODE(JTRUE , "jmpTrue" ,0,GTK_UNOP|GTK_NOVALUE) -GTNODE(LIST , "<list>" ,0,GTK_BINOP|GTK_NOVALUE) +GTNODE(LIST , "<list>" ,0,GTK_BINOP) //----------------------------------------------------------------------------- // Other nodes that have special structure: |