summaryrefslogtreecommitdiff
path: root/src/gc/gcinterface.h
diff options
context:
space:
mode:
authorSean Gillespie <sean@swgillespie.me>2017-04-14 09:51:10 -0700
committerGitHub <noreply@github.com>2017-04-14 09:51:10 -0700
commit13812bfd0f6eda442c944f416e8c871b18d99e3f (patch)
treed8f51b0fc4208e097fcbc82b3f385ebc8b45ab9a /src/gc/gcinterface.h
parent4c6f23eb3d1ee0e39d6df44ed573f6a0132f71fc (diff)
downloadcoreclr-13812bfd0f6eda442c944f416e8c871b18d99e3f.tar.gz
coreclr-13812bfd0f6eda442c944f416e8c871b18d99e3f.tar.bz2
coreclr-13812bfd0f6eda442c944f416e8c871b18d99e3f.zip
[Local GC] Move operations on CLREventStatic to the EE interface (#10813)
* [Local GC] Move operations on CLREventStatic to the EE and add their functionality to the interface * Fix a missed case * Split GetWaitForGCEvent into two smaller interface methods to avoid exposing the event itself on the interface * Initial implementation for Unix * Complete unix implementation * Make it work on Windows * Remove redudant methods from GCToEEInterface * Fix the Linux build * First part of code review feedback: make GCEvent dispatch statically (Windows) * Second part of code review feedback: make GCEvent dispatch statically (Unix) * Standardize implementation across Windows/Unix (apparently MSVC is more lenient about constructor names than clang) * Address code review feedback: Add Create*Event methods back onto GCEvent and remove them from GCToOSInterface * Address code review feedback: remove a dead define * Remove a bad comment, remove an unnecessary friend class, fix some formatting issues * Fix an issue when initializing a GCEvent on Linux (should not be allocating an Impl in the constructor) * Fix the same issue on Windows (less bad, just leaks memory instead of asserting)
Diffstat (limited to 'src/gc/gcinterface.h')
-rw-r--r--src/gc/gcinterface.h8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/gc/gcinterface.h b/src/gc/gcinterface.h
index cac2ba7114..4ebb5e15d7 100644
--- a/src/gc/gcinterface.h
+++ b/src/gc/gcinterface.h
@@ -687,9 +687,11 @@ public:
// background GC as the BGC threads also need to walk LOH.
virtual void PublishObject(uint8_t* obj) = 0;
- // Gets the event that suspended threads will use to wait for the
- // end of a GC.
- virtual CLREventStatic* GetWaitForGCEvent() = 0;
+ // Signals the WaitForGCEvent event, indicating that a GC has completed.
+ virtual void SetWaitForGCEvent() = 0;
+
+ // Resets the state of the WaitForGCEvent back to an unsignalled state.
+ virtual void ResetWaitForGCEvent() = 0;
/*
===========================================================================