diff options
| author | Andrew Au <andrewau@microsoft.com> | 2018-05-22 16:00:11 -0700 |
|---|---|---|
| committer | Andrew Au <cshung@gmail.com> | 2018-11-06 18:34:47 -0800 |
| commit | a00a15f6ab923ef9bfee8334f241f8163359316b (patch) | |
| tree | 80db61630d49e8ee83439a8ae7e95e214092b5f4 | |
| parent | c5a69820e866fff47c9f415d872112c58f17a717 (diff) | |
| download | coreclr-a00a15f6ab923ef9bfee8334f241f8163359316b.tar.gz coreclr-a00a15f6ab923ef9bfee8334f241f8163359316b.tar.bz2 coreclr-a00a15f6ab923ef9bfee8334f241f8163359316b.zip | |
Making sure issues are tracked by TODOs
| -rw-r--r-- | src/debug/ee/debugger.cpp | 1 | ||||
| -rw-r--r-- | src/inc/cordebug.idl | 2 |
2 files changed, 3 insertions, 0 deletions
diff --git a/src/debug/ee/debugger.cpp b/src/debug/ee/debugger.cpp index 3ddcf4ecef..8ef3378cf5 100644 --- a/src/debug/ee/debugger.cpp +++ b/src/debug/ee/debugger.cpp @@ -6040,6 +6040,7 @@ void Debugger::AfterGarbageCollection() } CONTRACTL_END; + // TODO, databp, ideally, remove this. CONTRACT_VIOLATION(GCViolation); if (!CORDebuggerAttached()) diff --git a/src/inc/cordebug.idl b/src/inc/cordebug.idl index e016ad2773..b275b69e33 100644 --- a/src/inc/cordebug.idl +++ b/src/inc/cordebug.idl @@ -1359,6 +1359,8 @@ interface ICorDebugManagedCallback3 : IUnknown interface ICorDebugManagedCallback4 : IUnknown { + // TODO, databp, these public APIs need to be commented. + // TODO, databp, measure performance to see if these events need to be switched. HRESULT BeforeGarbageCollection([in] ICorDebugProcess* pProcess); HRESULT AfterGarbageCollection([in] ICorDebugProcess* pProcess); HRESULT DataBreakpoint([in] ICorDebugProcess* pProcess, [in] ICorDebugThread* pThread, [in] ULONG64 dataBreakpointMask); |