diff options
| author | Samuel Iglesias Gonsálvez <siglesias@igalia.com> | 2020-04-02 11:00:26 +0200 |
|---|---|---|
| committer | Alexander Galazin <Alexander.Galazin@arm.com> | 2020-04-09 03:23:33 -0400 |
| commit | ecebf95a54d78a061f7138ad451b45d4ec88d219 (patch) | |
| tree | 8ed766ebe71b6bf3c597ed671c5c30146daeac36 | |
| parent | e69d916f62f1db42df99457aac98f5cff53b68bd (diff) | |
| download | VK-GL-CTS-ecebf95a54d78a061f7138ad451b45d4ec88d219.tar.gz VK-GL-CTS-ecebf95a54d78a061f7138ad451b45d4ec88d219.tar.bz2 VK-GL-CTS-ecebf95a54d78a061f7138ad451b45d4ec88d219.zip | |
Remove TODO, FIXME that were left behind
After checking pending TODOs and FIXMEs, found some that were
added when writing the tests and I forgot to remove them before
submitting the tests for review.
Components: Vulkan
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: Ic6c93886208127934814184561ff02c05c95d1e2
3 files changed, 0 insertions, 6 deletions
diff --git a/external/vulkancts/modules/vulkan/pipeline/vktPipelineReferenceRenderer.hpp b/external/vulkancts/modules/vulkan/pipeline/vktPipelineReferenceRenderer.hpp index 62490aaa2..431dbd6ca 100644 --- a/external/vulkancts/modules/vulkan/pipeline/vktPipelineReferenceRenderer.hpp +++ b/external/vulkancts/modules/vulkan/pipeline/vktPipelineReferenceRenderer.hpp @@ -221,7 +221,6 @@ public: m_inputs[1].type = rr::GENERICVECTYPE_FLOAT; m_inputs[2].type = rr::GENERICVECTYPE_FLOAT; - // XXX: Should m_outputs[1] need to be added? m_outputs[0].type = (channelClass == tcu::TEXTURECHANNELCLASS_SIGNED_INTEGER)? rr::GENERICVECTYPE_INT32 : (channelClass == tcu::TEXTURECHANNELCLASS_UNSIGNED_INTEGER)? rr::GENERICVECTYPE_UINT32 : rr::GENERICVECTYPE_FLOAT; diff --git a/external/vulkancts/modules/vulkan/query_pool/vktQueryPoolConcurrentTests.hpp b/external/vulkancts/modules/vulkan/query_pool/vktQueryPoolConcurrentTests.hpp index 6c49c12da..918db5160 100644 --- a/external/vulkancts/modules/vulkan/query_pool/vktQueryPoolConcurrentTests.hpp +++ b/external/vulkancts/modules/vulkan/query_pool/vktQueryPoolConcurrentTests.hpp @@ -40,7 +40,6 @@ public: private: QueryPoolConcurrentTests (const QueryPoolConcurrentTests &other); - // TODO: Do I need this operator? QueryPoolConcurrentTests& operator= (const QueryPoolConcurrentTests &other); }; diff --git a/external/vulkancts/modules/vulkan/renderpass/vktRenderPassMultipleSubpassesMultipleCommandBuffersTests.cpp b/external/vulkancts/modules/vulkan/renderpass/vktRenderPassMultipleSubpassesMultipleCommandBuffersTests.cpp index 91f64fdbf..69d58b4d1 100644 --- a/external/vulkancts/modules/vulkan/renderpass/vktRenderPassMultipleSubpassesMultipleCommandBuffersTests.cpp +++ b/external/vulkancts/modules/vulkan/renderpass/vktRenderPassMultipleSubpassesMultipleCommandBuffersTests.cpp @@ -101,7 +101,6 @@ private: static constexpr deUint32 kImageHeight = 32; const tcu::UVec2 m_renderSize = { kImageWidth, kImageHeight }; - // FIXME: check if I need all of this. VkClearValue m_initialColor; VkClearValue m_clearColor; @@ -180,7 +179,6 @@ void MultipleSubpassesMultipleCommandBuffersTest::initPrograms (SourceCollection // Create a render pass for this use case. Move<VkRenderPass> createRenderPass (const DeviceInterface& vk, VkDevice vkDevice) { - // XXX: Add more code to this // Create attachment descriptions. const VkAttachmentDescription attachmentDescription = { @@ -195,7 +193,6 @@ Move<VkRenderPass> createRenderPass (const DeviceInterface& vk, VkDevice vkDevic VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL // VkImageLayout finalLayout }; - // XXX: Review this parameters, I think I am doing it wrong. // Mark attachments as used or not depending on the test parameters. const VkAttachmentReference attachmentReference { @@ -820,7 +817,6 @@ tcu::TestStatus MultipleSubpassesMultipleCommandBuffersTestInstance::iterate (vo VK_CHECK(vk.waitForFences(vkDevice, 1u, &fence.get(), DE_TRUE, ~0ull)); } - // XXX: Add code for image verification for both color attachments { // Colors to compare to. const tcu::Vec4 red = {1.0f, 0.0f, 0.0f, 1.0f}; |