diff options
author | Rasmus Villemoes <rasmus.villemoes@prevas.dk> | 2024-01-03 11:47:03 +0100 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2024-01-16 17:05:29 -0500 |
commit | d631681e8c5f255938283233cd0f55ed2f9a9a76 (patch) | |
tree | d51ec3a709b86a8ef44491dce95a735c447f02f8 /cmd/mem.c | |
parent | 22efc1cf276c0b0ca5622e4e85135e920b3efa9c (diff) | |
download | u-boot-d631681e8c5f255938283233cd0f55ed2f9a9a76.tar.gz u-boot-d631681e8c5f255938283233cd0f55ed2f9a9a76.tar.bz2 u-boot-d631681e8c5f255938283233cd0f55ed2f9a9a76.zip |
cmd/mem.c: use memmove in do_mem_cp()
There's no 'mv' shell command for handling overlapping src and dst
regions, and there's no point introducing one, when we can just make
the existing 'cp' command DTRT in all cases. memmove() should at most
be a few instructions more then memcpy() (to detect the appropriate
direction to do the copy), which is of course completely in the noise
with all the string processing that a shell command does.
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Diffstat (limited to 'cmd/mem.c')
-rw-r--r-- | cmd/mem.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -361,7 +361,7 @@ static int do_mem_cp(struct cmd_tbl *cmdtp, int flag, int argc, } #endif - memcpy(dst, src, count * size); + memmove(dst, src, count * size); unmap_sysmem(src); unmap_sysmem(dst); |