diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/isee | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
| download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.bz2 u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/isee')
| -rw-r--r-- | board/isee/igep003x/board.c | 4 | ||||
| -rw-r--r-- | board/isee/igep00x0/common.c | 2 | ||||
| -rw-r--r-- | board/isee/igep00x0/igep00x0.c | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/board/isee/igep003x/board.c b/board/isee/igep003x/board.c index a28d447825..9b4cb91b34 100644 --- a/board/isee/igep003x/board.c +++ b/board/isee/igep003x/board.c @@ -212,7 +212,7 @@ int board_late_init(void) #endif #ifdef CONFIG_OF_BOARD_SETUP -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_FDT_FIXUP_PARTITIONS static const struct node_info nodes[] = { @@ -261,7 +261,7 @@ static struct cpsw_platform_data cpsw_data = { .version = CPSW_CTRL_VERSION_2, }; -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rv, ret = 0; uint8_t mac_addr[6]; diff --git a/board/isee/igep00x0/common.c b/board/isee/igep00x0/common.c index 2c269773a8..58c713f0f3 100644 --- a/board/isee/igep00x0/common.c +++ b/board/isee/igep00x0/common.c @@ -56,7 +56,7 @@ int board_init(void) } #if defined(CONFIG_MMC) -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { return omap_mmc_init(0, 0, 0, -1, -1); } diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c index af0bce6426..e0ca3c2588 100644 --- a/board/isee/igep00x0/igep00x0.c +++ b/board/isee/igep00x0/igep00x0.c @@ -132,7 +132,7 @@ static void setup_net_chip(void) reset_net_chip(64); } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { #ifdef CONFIG_SMC911X return smc911x_initialize(0, CONFIG_SMC911X_BASE); @@ -159,7 +159,7 @@ static int ft_enable_by_compatible(void *blob, char *compat, int enable) return 0; } -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_FDT_FIXUP_PARTITIONS static const struct node_info nodes[] = { |