diff options
| author | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2024-03-16 10:36:44 +0100 |
|---|---|---|
| committer | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2024-03-21 07:28:43 +0100 |
| commit | 68fc0b877b5ddc93eb542ffa26dcf83e7e2860a8 (patch) | |
| tree | 563b940941e8998f717f9ed4995551054d436af4 | |
| parent | 46e5dd661c82a99b9ac8d302cbbc575f74b6b08b (diff) | |
| download | u-boot-68fc0b877b5ddc93eb542ffa26dcf83e7e2860a8.tar.gz u-boot-68fc0b877b5ddc93eb542ffa26dcf83e7e2860a8.tar.bz2 u-boot-68fc0b877b5ddc93eb542ffa26dcf83e7e2860a8.zip | |
cmd: bootefi: error handling bootefi selftest
If bootefi selftest is executed and a problem with the device-tree
installation occurs, efi_install_fdt() writes sensible error messages.
It never returns EFI_INVALID_PARAMETER. It neither makes sense to check
for EFI_INVALID_PARAMETER nor to show the usage help for the bootefi
command in this case.
Fixes: 296faf4f7ef1 ("cmd: bootefi: re-organize do_bootefi()")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
| -rw-r--r-- | cmd/bootefi.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/cmd/bootefi.c b/cmd/bootefi.c index b509440cde..578dbb19a7 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -171,9 +171,7 @@ static int do_bootefi(struct cmd_tbl *cmdtp, int flag, int argc, } ret = efi_install_fdt(fdt); - if (ret == EFI_INVALID_PARAMETER) - return CMD_RET_USAGE; - else if (ret != EFI_SUCCESS) + if (ret != EFI_SUCCESS) return CMD_RET_FAILURE; return do_efi_selftest(); |