diff options
| author | Simon Glass <sjg@chromium.org> | 2016-03-06 19:27:53 -0700 |
|---|---|---|
| committer | Bin Meng <bmeng.cn@gmail.com> | 2016-03-17 10:27:23 +0800 |
| commit | 4974a6ff048fecba6077bf3101c6aba830e038c7 (patch) | |
| tree | 29f6d1e3e4a567f4db5a167a94d8690a733f9584 | |
| parent | 319dba1f4d7bf2c82be1c5b0858c4b1c3d8b4cfe (diff) | |
| download | u-boot-4974a6ff048fecba6077bf3101c6aba830e038c7.tar.gz u-boot-4974a6ff048fecba6077bf3101c6aba830e038c7.tar.bz2 u-boot-4974a6ff048fecba6077bf3101c6aba830e038c7.zip | |
pci: Correct a few comments and nits
Two comments are missing a parameter and there is an extra blank line. Also
two of the region access macros are misnamed. Correct these problems.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
| -rw-r--r-- | drivers/pci/pci-uclass.c | 1 | ||||
| -rw-r--r-- | include/pci.h | 6 |
2 files changed, 4 insertions, 3 deletions
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index cb5101493b..c7fbf7bf66 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -289,7 +289,6 @@ int dm_pci_write_config(struct udevice *dev, int offset, unsigned long value, size); } - int pci_write_config32(pci_dev_t bdf, int offset, u32 value) { return pci_write_config(bdf, offset, value, PCI_SIZE_32); diff --git a/include/pci.h b/include/pci.h index db84744571..87de7ab715 100644 --- a/include/pci.h +++ b/include/pci.h @@ -1007,6 +1007,7 @@ int dm_pci_hose_probe_bus(struct udevice *bus); * * @bus: Bus to read from * @bdf: PCI device address: bus, device and function -see PCI_BDF() + * @offset: Register offset to read * @valuep: Place to put the returned value * @size: Access size * @return 0 if OK, -ve on error @@ -1019,6 +1020,7 @@ int pci_bus_read_config(struct udevice *bus, pci_dev_t bdf, int offset, * * @bus: Bus to write from * @bdf: PCI device address: bus, device and function -see PCI_BDF() + * @offset: Register offset to write * @value: Value to write * @size: Access size * @return 0 if OK, -ve on error @@ -1260,9 +1262,9 @@ void *dm_pci_map_bar(struct udevice *dev, int bar, int flags); #define dm_pci_mem_to_virt(dev, addr, len, map_flags) \ dm_pci_bus_to_virt((dev), (addr), PCI_REGION_MEM, (len), (map_flags)) #define dm_pci_virt_to_io(dev, addr) \ - dm_dm_pci_virt_to_bus((dev), (addr), PCI_REGION_IO) + dm_pci_virt_to_bus((dev), (addr), PCI_REGION_IO) #define dm_pci_io_to_virt(dev, addr, len, map_flags) \ - dm_dm_pci_bus_to_virt((dev), (addr), PCI_REGION_IO, (len), (map_flags)) + dm_pci_bus_to_virt((dev), (addr), PCI_REGION_IO, (len), (map_flags)) /** * dm_pci_find_device() - find a device by vendor/device ID |