diff options
| author | Pali Rohár <pali@kernel.org> | 2023-04-13 22:41:46 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2023-05-01 18:59:33 -0400 |
| commit | 159f104076d4a0693599900deb8173f2af5942a4 (patch) | |
| tree | 723a1f2c5772d4cb4a19148fd0b469e7b9c1b15b | |
| parent | f5375a4500b2491f8315288dcaff3578e8b4c800 (diff) | |
| download | u-boot-159f104076d4a0693599900deb8173f2af5942a4.tar.gz u-boot-159f104076d4a0693599900deb8173f2af5942a4.tar.bz2 u-boot-159f104076d4a0693599900deb8173f2af5942a4.zip | |
pci: mpc85xx: Do not try to access extended PCIe registers
Driver pci_mpc85xx.c is PCI controller driver for old PCI Local Bus,
which does not support access to extended PCIe registers (above 0xff),
as opposite of the PCIe driver pcie_fsl.c for the same platform.
So do not try to access extended PCIe registers as it cannot work.
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Heiko Schocher <hs@denx.de>
Tested-by: Heiko Schocher <hs@denx.de>
| -rw-r--r-- | drivers/pci/pci_mpc85xx.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/pci/pci_mpc85xx.c b/drivers/pci/pci_mpc85xx.c index d144f2b791..833de816c4 100644 --- a/drivers/pci/pci_mpc85xx.c +++ b/drivers/pci/pci_mpc85xx.c @@ -22,7 +22,12 @@ static int mpc85xx_pci_dm_read_config(const struct udevice *dev, pci_dev_t bdf, struct mpc85xx_pci_priv *priv = dev_get_priv(dev); u32 addr; - addr = PCI_CONF1_EXT_ADDRESS(PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf), offset); + if (offset > 0xff) { + *value = pci_get_ff(size); + return 0; + } + + addr = PCI_CONF1_ADDRESS(PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf), offset); out_be32(priv->cfg_addr, addr); sync(); @@ -48,7 +53,10 @@ static int mpc85xx_pci_dm_write_config(struct udevice *dev, pci_dev_t bdf, struct mpc85xx_pci_priv *priv = dev_get_priv(dev); u32 addr; - addr = PCI_CONF1_EXT_ADDRESS(PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf), offset); + if (offset > 0xff) + return 0; + + addr = PCI_CONF1_ADDRESS(PCI_BUS(bdf), PCI_DEV(bdf), PCI_FUNC(bdf), offset); out_be32(priv->cfg_addr, addr); sync(); |