summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorSasha Levin <sasha.levin@oracle.com>2014-07-14 17:02:31 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-08-07 14:52:39 -0700
commit5a47f7ed643ef221a645da68031bfdfd36340aa1 (patch)
tree7bf88df74b101fddb1ee3384c37f5d0469864431 /lib
parente4cbf9a98c9ed2d1578399928bb101dca7b95c5e (diff)
downloadlinux-stable-5a47f7ed643ef221a645da68031bfdfd36340aa1.tar.gz
linux-stable-5a47f7ed643ef221a645da68031bfdfd36340aa1.tar.bz2
linux-stable-5a47f7ed643ef221a645da68031bfdfd36340aa1.zip
net/l2tp: don't fall back on UDP [get|set]sockopt
commit 3cf521f7dc87c031617fd47e4b7aa2593c2f3daf upstream. The l2tp [get|set]sockopt() code has fallen back to the UDP functions for socket option levels != SOL_PPPOL2TP since day one, but that has never actually worked, since the l2tp socket isn't an inet socket. As David Miller points out: "If we wanted this to work, it'd have to look up the tunnel and then use tunnel->sk, but I wonder how useful that would be" Since this can never have worked so nobody could possibly have depended on that functionality, just remove the broken code and return -EINVAL. Reported-by: Sasha Levin <sasha.levin@oracle.com> Acked-by: James Chapman <jchapman@katalix.com> Acked-by: David Miller <davem@davemloft.net> Cc: Phil Turnbull <phil.turnbull@oracle.com> Cc: Vegard Nossum <vegard.nossum@oracle.com> Cc: Willy Tarreau <w@1wt.eu> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions