diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2011-07-23 18:18:58 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-07-24 10:12:01 -0400 |
| commit | 963945bf93e46b9bf71a07bf9c78183e0f57733a (patch) | |
| tree | 736c84e9a31b2dd736293ca117688527e3a5a194 /fs/jffs2 | |
| parent | 1ec95bf34d976b38897d1977b155a544d77b05e7 (diff) | |
| download | linux-stable-963945bf93e46b9bf71a07bf9c78183e0f57733a.tar.gz linux-stable-963945bf93e46b9bf71a07bf9c78183e0f57733a.tar.bz2 linux-stable-963945bf93e46b9bf71a07bf9c78183e0f57733a.zip | |
fix jffs2 ACLs on big-endian with 16bit mode_t
casting int * to mode_t * is not a good thing - on a *lot* of big-endian
architectures mode_t happens to be smaller than int and there it breaks
quite spectaculary...
Fucked-up-by: commit cfc8dc6f6f69ede939e09c2af06a01adee577285
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/jffs2')
| -rw-r--r-- | fs/jffs2/acl.c | 4 | ||||
| -rw-r--r-- | fs/jffs2/acl.h | 2 | ||||
| -rw-r--r-- | fs/jffs2/fs.c | 2 | ||||
| -rw-r--r-- | fs/jffs2/os-linux.h | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c index 3675b3cdee89..f9c302430aa1 100644 --- a/fs/jffs2/acl.c +++ b/fs/jffs2/acl.c @@ -278,7 +278,7 @@ int jffs2_check_acl(struct inode *inode, int mask) return -EAGAIN; } -int jffs2_init_acl_pre(struct inode *dir_i, struct inode *inode, int *i_mode) +int jffs2_init_acl_pre(struct inode *dir_i, struct inode *inode, mode_t *i_mode) { struct posix_acl *acl, *clone; int rc; @@ -301,7 +301,7 @@ int jffs2_init_acl_pre(struct inode *dir_i, struct inode *inode, int *i_mode) clone = posix_acl_clone(acl, GFP_KERNEL); if (!clone) return -ENOMEM; - rc = posix_acl_create_masq(clone, (mode_t *)i_mode); + rc = posix_acl_create_masq(clone, i_mode); if (rc < 0) { posix_acl_release(clone); return rc; diff --git a/fs/jffs2/acl.h b/fs/jffs2/acl.h index 5e42de8d9541..9973073b9c47 100644 --- a/fs/jffs2/acl.h +++ b/fs/jffs2/acl.h @@ -28,7 +28,7 @@ struct jffs2_acl_header { extern int jffs2_check_acl(struct inode *, int); extern int jffs2_acl_chmod(struct inode *); -extern int jffs2_init_acl_pre(struct inode *, struct inode *, int *); +extern int jffs2_init_acl_pre(struct inode *, struct inode *, mode_t *); extern int jffs2_init_acl_post(struct inode *); extern const struct xattr_handler jffs2_acl_access_xattr_handler; diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c index 46ad619b6124..eeead33d8ef0 100644 --- a/fs/jffs2/fs.c +++ b/fs/jffs2/fs.c @@ -406,7 +406,7 @@ int jffs2_remount_fs (struct super_block *sb, int *flags, char *data) /* jffs2_new_inode: allocate a new inode and inocache, add it to the hash, fill in the raw_inode while you're at it. */ -struct inode *jffs2_new_inode (struct inode *dir_i, int mode, struct jffs2_raw_inode *ri) +struct inode *jffs2_new_inode (struct inode *dir_i, mode_t mode, struct jffs2_raw_inode *ri) { struct inode *inode; struct super_block *sb = dir_i->i_sb; diff --git a/fs/jffs2/os-linux.h b/fs/jffs2/os-linux.h index 9c252835e8e5..526979c607b6 100644 --- a/fs/jffs2/os-linux.h +++ b/fs/jffs2/os-linux.h @@ -173,7 +173,7 @@ int jffs2_do_setattr (struct inode *, struct iattr *); struct inode *jffs2_iget(struct super_block *, unsigned long); void jffs2_evict_inode (struct inode *); void jffs2_dirty_inode(struct inode *inode, int flags); -struct inode *jffs2_new_inode (struct inode *dir_i, int mode, +struct inode *jffs2_new_inode (struct inode *dir_i, mode_t mode, struct jffs2_raw_inode *ri); int jffs2_statfs (struct dentry *, struct kstatfs *); int jffs2_remount_fs (struct super_block *, int *, char *); |