summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/intel
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-01-15 06:43:39 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-06-07 10:28:18 -0700
commit8a255ad5da168d12278f6a59bb2727ca07416c9d (patch)
treeba4750db86f90508d91b71f9628dee4c371d3c6f /drivers/net/ethernet/intel
parentcd3750a8e7a512616c64c729a8de4d4d0bd69b7e (diff)
downloadlinux-stable-8a255ad5da168d12278f6a59bb2727ca07416c9d.tar.gz
linux-stable-8a255ad5da168d12278f6a59bb2727ca07416c9d.tar.bz2
linux-stable-8a255ad5da168d12278f6a59bb2727ca07416c9d.zip
i40e: potential array underflow in i40e_vc_process_vf_msg()
commit c243e96335c56e56dcf6a00593104554fb06b689 upstream. If "vf_id" is smaller than hw->func_caps.vf_base_id then it leads to an array underflow of the pf->vf[] array. This is unlikely to happen unless the hardware is bad, but it's a small change and it silences a static checker warning. Fixes: 7efa84b7abc1 ('i40e: support VFs on PFs other than 0') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Tested-by: Sibai Li <sibai.li@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/ethernet/intel')
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index b9d1c1c8ca5a..178506a201d5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -1776,7 +1776,7 @@ int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16 vf_id, u32 v_opcode,
u32 v_retval, u8 *msg, u16 msglen)
{
struct i40e_hw *hw = &pf->hw;
- int local_vf_id = vf_id - hw->func_caps.vf_base_id;
+ unsigned int local_vf_id = vf_id - hw->func_caps.vf_base_id;
struct i40e_vf *vf;
int ret;