diff options
| author | Max Uvarov <muvarov@gmail.com> | 2019-05-28 13:00:52 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-22 08:15:20 +0200 |
| commit | 7b9e10944f0dc82627321288a3012c2cf233f85d (patch) | |
| tree | f56a2569bd36eb7919cf3443a007da12bcb34823 | |
| parent | 7698ad8c14c7ba8fc4364e6c9150c94203de7333 (diff) | |
| download | linux-rpi3-7b9e10944f0dc82627321288a3012c2cf233f85d.tar.gz linux-rpi3-7b9e10944f0dc82627321288a3012c2cf233f85d.tar.bz2 linux-rpi3-7b9e10944f0dc82627321288a3012c2cf233f85d.zip | |
net: phy: dp83867: Set up RGMII TX delay
[ Upstream commit 2b892649254fec01678c64f16427622b41fa27f4 ]
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.
Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov <muvarov@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/phy/dp83867.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index b3935778b19f..e4bf9e7d7583 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -260,10 +260,8 @@ static int dp83867_config_init(struct phy_device *phydev) ret = phy_write(phydev, MII_DP83867_PHYCTRL, val); if (ret) return ret; - } - if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) && - (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) { + /* Set up RGMII delays */ val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL); if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) |